[issue38474] digit check logic can be replaced by Py_ISDIGIT on prepare_s

Change by Dong-hee Na : -- resolution: -> wont fix stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue38474] digit check logic can be replaced by Py_ISDIGIT on prepare_s

Dong-hee Na added the comment: > I'm inclined to agree: the current code works and is efficient; there's no > strong reason to change it. Okay, then I will close the PR. I respect core developer's opinions. -- ___ Python tracker

[issue38474] digit check logic can be replaced by Py_ISDIGIT on prepare_s

Mark Dickinson added the comment: > Rewriting all this code just because we have Py_ISDIGIT() is a code churn. I'm inclined to agree: the current code works and is efficient; there's no strong reason to change it. -- ___ Python tracker

[issue38474] digit check logic can be replaced by Py_ISDIGIT on prepare_s

Serhiy Storchaka added the comment: I left this on to the struct module maintainers. -- nosy: +mark.dickinson, meador.inge ___ Python tracker ___

[issue38474] digit check logic can be replaced by Py_ISDIGIT on prepare_s

Serhiy Storchaka added the comment: It was added as a replacement of locale aware isdigit(). It was initially used only for implementing bytes.isdigit() and in PyOS_ascii_strtod(). isdigit() is not used in Modules/_struct.c, so there is nothing to replace with Py_ISDIGIT(). Currently

[issue38474] digit check logic can be replaced by Py_ISDIGIT on prepare_s

Dong-hee Na added the comment: > What is the benefit of such change? I think that if an API is implemented for a specific purpose, it should be used. This will help us to maintain code quality. Especially in the case of pointed out logics, since Py_ISDIGIT is exactly what we want to do, By

[issue38474] digit check logic can be replaced by Py_ISDIGIT on prepare_s

Serhiy Storchaka added the comment: What is the benefit of such change? -- nosy: +serhiy.storchaka ___ Python tracker ___ ___

[issue38474] digit check logic can be replaced by Py_ISDIGIT on prepare_s

Change by Dong-hee Na : -- versions: +Python 3.7, Python 3.8, Python 3.9 ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue38474] digit check logic can be replaced by Py_ISDIGIT on prepare_s

Change by Dong-hee Na : -- keywords: +patch pull_requests: +16347 stage: -> patch review pull_request: https://github.com/python/cpython/pull/16787 ___ Python tracker ___

[issue38474] digit check logic can be replaced by Py_ISDIGIT on prepare_s

New submission from Dong-hee Na : digit check logic can be replaced by Py_ISDIGIT on prepare_s. -- assignee: corona10 messages: 354643 nosy: corona10 priority: normal severity: normal status: open title: digit check logic can be replaced by Py_ISDIGIT on prepare_s