[issue38530] Offer suggestions on AttributeError and NameError

Pablo Galindo Salgado added the comment: New changeset 80a2a4ed7d090fff2584302f07315d567109bca9 by Dennis Sweeney in branch 'master': bpo-38530: Refactor and improve AttributeError suggestions (GH-25776) https://github.com/python/cpython/commit/80a2a4ed7d090fff2584302f07315d567109bca9 -

[issue38530] Offer suggestions on AttributeError and NameError

Dennis Sweeney added the comment: PR 25776 is a work in progress for what it might look like to do a few things: - Make case-swaps half the cost of any other edit - Refactor Levenshtein code to not use memory allocator, and to bail early on no match. - Add comments to Levenshtein distance cod

[issue38530] Offer suggestions on AttributeError and NameError

Change by Dennis Sweeney : -- pull_requests: +24466 pull_request: https://github.com/python/cpython/pull/25776 ___ Python tracker ___ __

[issue38530] Offer suggestions on AttributeError and NameError

Pablo Galindo Salgado added the comment: Hi Dennis, this is a fantastic investigation! I think I really like GCC approach here. We may want to invest into porting some of their ideas into our solution. -- ___ Python tracker

[issue38530] Offer suggestions on AttributeError and NameError

Dennis Sweeney added the comment: Some research of other projects: LLVM [1][2] --- - Compute Levenshtein - Using O(n) memory rather than O(n^2) - Uses UpperBound = (len(typo) + 2) // 3 GCC [3] --- - Uses Damerau-Levenshtein distance - Counts transpositions like "abcd" <

[issue38530] Offer suggestions on AttributeError and NameError

Pablo Galindo Salgado added the comment: New changeset 284c52da092438522949d6f96d8c1f9ff37f9f00 by Dennis Sweeney in branch 'master': bpo-38530: Require 50% similarity in NameError and AttributeError suggestions (GH-25584) https://github.com/python/cpython/commit/284c52da092438522949d6f96d8c

[issue38530] Offer suggestions on AttributeError and NameError

Dennis Sweeney added the comment: I opened PR 25584 to fix this current behavior: >>> v Traceback (most recent call last): File "", line 1, in NameError: name 'v' is not defined. Did you mean: 'id'? >>> vv Traceback (most recent call last): File "", line 1, in NameError: name 'vv' is not

[issue38530] Offer suggestions on AttributeError and NameError

Change by Dennis Sweeney : -- nosy: +Dennis Sweeney nosy_count: 8.0 -> 9.0 pull_requests: +24304 pull_request: https://github.com/python/cpython/pull/25584 ___ Python tracker _

[issue38530] Offer suggestions on AttributeError and NameError

Change by Pablo Galindo Salgado : -- pull_requests: +24201 pull_request: https://github.com/python/cpython/pull/25473 ___ Python tracker ___ ___

[issue38530] Offer suggestions on AttributeError and NameError

Pablo Galindo Salgado added the comment: New changeset 0b1c169c4a009e1094fe5df938d2367e63ebeea0 by Pablo Galindo in branch 'master': bpo-38530: Cover more error paths in error suggestion functions (GH-25462) https://github.com/python/cpython/commit/0b1c169c4a009e1094fe5df938d2367e63ebeea0 -

[issue38530] Offer suggestions on AttributeError and NameError

Change by Pablo Galindo Salgado : -- pull_requests: +24188 pull_request: https://github.com/python/cpython/pull/25462 ___ Python tracker ___ ___

[issue38530] Offer suggestions on AttributeError and NameError

Pablo Galindo Salgado added the comment: New changeset 3ab4bea5a3ac28820781cf62a768c65370c9054c by Pablo Galindo in branch 'master': bpo-38530: Include builtins in NameError suggestions (GH-25460) https://github.com/python/cpython/commit/3ab4bea5a3ac28820781cf62a768c65370c9054c --

[issue38530] Offer suggestions on AttributeError and NameError

Change by Pablo Galindo Salgado : -- pull_requests: +24187 pull_request: https://github.com/python/cpython/pull/25460 ___ Python tracker ___ ___

[issue38530] Offer suggestions on AttributeError and NameError

Pablo Galindo Salgado added the comment: New changeset 0ad81d4db2f409d72f469d0b74ab597be772a68e by Pablo Galindo in branch 'master': bpo-38530: Match exactly AttributeError and NameError when offering suggestions (GH-25443) https://github.com/python/cpython/commit/0ad81d4db2f409d72f469d0b74a

[issue38530] Offer suggestions on AttributeError and NameError

Pablo Galindo Salgado added the comment: New changeset 3b82cae774638ecf2baaee8fe2cac8fedafb2ca7 by Pablo Galindo in branch 'master': bpo-38530: Properly extend UnboundLocalError from NameError (GH-25444) https://github.com/python/cpython/commit/3b82cae774638ecf2baaee8fe2cac8fedafb2ca7 -

[issue38530] Offer suggestions on AttributeError and NameError

Change by Pablo Galindo Salgado : -- pull_requests: +24174 pull_request: https://github.com/python/cpython/pull/25444 ___ Python tracker ___ ___

[issue38530] Offer suggestions on AttributeError and NameError

Change by Pablo Galindo Salgado : -- pull_requests: +24173 pull_request: https://github.com/python/cpython/pull/25443 ___ Python tracker ___ ___

[issue38530] Offer suggestions on AttributeError and NameError

STINNER Victor added the comment: I like the https://docs.python.org/dev/whatsnew/3.10.html#better-error-messages section: well done, thanks ;-) -- ___ Python tracker ___ ___

[issue38530] Offer suggestions on AttributeError and NameError

Change by Pablo Galindo Salgado : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___

[issue38530] Offer suggestions on AttributeError and NameError

Pablo Galindo Salgado added the comment: New changeset 3fc65b97d09fd29272fdf60d2e567bfb070da824 by Pablo Galindo in branch 'master': bpo-38530: Optimize the calculation of string sizes when offering suggestions (GH-25412) https://github.com/python/cpython/commit/3fc65b97d09fd29272fdf60d2e567

[issue38530] Offer suggestions on AttributeError and NameError

Change by Pablo Galindo Salgado : -- pull_requests: +24144 pull_request: https://github.com/python/cpython/pull/25412 ___ Python tracker ___ ___

[issue38530] Offer suggestions on AttributeError and NameError

Pablo Galindo Salgado added the comment: New changeset e07f4ab26aaf08f90ebd9e6004af14fd6ef39351 by Pablo Galindo in branch 'master': bpo-38530: Make sure that failing to generate suggestions on failure will not propagate exceptions (GH-25408) https://github.com/python/cpython/commit/e07f4ab2

[issue38530] Offer suggestions on AttributeError and NameError

Change by Pablo Galindo Salgado : -- pull_requests: +24141 pull_request: https://github.com/python/cpython/pull/25408 ___ Python tracker ___ ___

[issue38530] Offer suggestions on AttributeError and NameError

Pablo Galindo Salgado added the comment: New changeset 5bf8bf2267cd109970b2d946d43b2e9f71379ba2 by Pablo Galindo in branch 'master': bpo-38530: Offer suggestions on NameError (GH-25397) https://github.com/python/cpython/commit/5bf8bf2267cd109970b2d946d43b2e9f71379ba2 -- ___

[issue38530] Offer suggestions on AttributeError and NameError

Change by Andre Roberge : -- nosy: +aroberge ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pyt

[issue38530] Offer suggestions on AttributeError and NameError

Change by Pablo Galindo Salgado : -- pull_requests: +24129 pull_request: https://github.com/python/cpython/pull/25397 ___ Python tracker ___ ___

[issue38530] Offer suggestions on AttributeError and NameError

Change by Pablo Galindo Salgado : -- title: Offer suggestions on AttributeError -> Offer suggestions on AttributeError and NameError ___ Python tracker ___ ___