[issue38547] test_pty fails when using setsid()

miss-islington added the comment: New changeset d08fd298dc8d5631f6c504d01ee4f9cfb47db79d by Miss Islington (bot) in branch '3.8': bpo-38547: Fix test_pty if the process is the session leader (GH-17519) https://github.com/python/cpython/commit/d08fd298dc8d5631f6c504d01ee4f9cfb47db79d ---

[issue38547] test_pty fails when using setsid()

miss-islington added the comment: New changeset b9f4b49c6e525afd6fce02cfc14be52e98a18f67 by Miss Islington (bot) in branch '3.7': bpo-38547: Fix test_pty if the process is the session leader (GH-17519) https://github.com/python/cpython/commit/b9f4b49c6e525afd6fce02cfc14be52e98a18f67 ---

[issue38547] test_pty fails when using setsid()

STINNER Victor added the comment: Ok, I merged my fix to master. The backport to 3.7 and 3.8 will follow quickly. I close the issue. Sorry for the inconvenience ;-) -- resolution: -> fixed stage: patch review -> resolved status: open -> closed __

[issue38547] test_pty fails when using setsid()

Change by miss-islington : -- pull_requests: +16998 pull_request: https://github.com/python/cpython/pull/17520 ___ Python tracker ___ __

[issue38547] test_pty fails when using setsid()

STINNER Victor added the comment: New changeset a1838ec2592e5082c75c77888f2a7a3eb21133e5 by Victor Stinner in branch 'master': bpo-38547: Fix test_pty if the process is the session leader (GH-17519) https://github.com/python/cpython/commit/a1838ec2592e5082c75c77888f2a7a3eb21133e5 --

[issue38547] test_pty fails when using setsid()

Change by miss-islington : -- pull_requests: +16999 pull_request: https://github.com/python/cpython/pull/17521 ___ Python tracker ___ __

[issue38547] test_pty fails when using setsid()

STINNER Victor added the comment: > I think fixing the underlying pty issue should certainly be the goal (...) I wrote PR 17519 which fix the bug. We just have to ignore SIGHUP signal. -- ___ Python tracker ___

[issue38547] test_pty fails when using setsid()

Change by STINNER Victor : -- keywords: +patch pull_requests: +16997 stage: -> patch review pull_request: https://github.com/python/cpython/pull/17519 ___ Python tracker ___ _

[issue38547] test_pty fails when using setsid()

David Bolen added the comment: I think fixing the underlying pty issue should certainly be the goal, but the question is whether the process group change should remain active in the meantime, as its presence is causing a regression in the tests. I think such cases in the past are usually ro

[issue38547] test_pty fails when using setsid()

STINNER Victor added the comment: Can't we fix test_pty? -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue38547] test_pty fails when using setsid()

Pablo Galindo Salgado added the comment: > What do you mean by "limited"? I mean to deactivate it by default and make opt-in. > Process groups really help to prevent to leak grandchild processes in > multiprocessing tests, when tests are interrupted manually by CTRL+C or by a > timeout (sad

[issue38547] test_pty fails when using setsid()

STINNER Victor added the comment: > I think this needs to be fixed or process groups in regrtest should be > limited or reverted. What do you mean by "limited"? Process groups really help to prevent to leak grandchild processes in multiprocessing tests, when tests are interrupted manually b

[issue38547] test_pty fails when using setsid()

Pablo Galindo Salgado added the comment: Indeed, almost all buildbots have to repeat the test_pty. I think this needs to be fixed or process groups in regrtest should be limited or reverted. -- ___ Python tracker

[issue38547] test_pty fails when using setsid()

Pablo Galindo Salgado added the comment: This also happens when running the test suite with high parallelism: ./python -m test -j 20 This fails with: == Tests result: FAILURE == 398 tests OK. 2 tests failed: test_embed test_pty -- nosy: +pablogsal ___

[issue38547] test_pty fails when using setsid()

Change by David Bolen : -- nosy: +db3l ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.or

[issue38547] test_pty fails when using setsid()

New submission from STINNER Victor : regrtest has been modified in bpo-38502 to use setsid() when using multiprocessing mode (-jN command line option). Problem: David Bolen identified that test_pty started to fail on his bolen-ubuntu worker (Ubuntu 18.04.3) since my commit ecb035cd14c1152127