[issue38598] IDLE: Disable F5, etc, in Shell and Output windows.

Tal Einat added the comment: As a better design for a long-term fix, I suggest: * Avoiding isinstance() checks by instead using a dedicated class attribute and checking that. (I've recently used this pattern for line numbers.) * Instead of baling out inside the "check module" and "run" handle

[issue38598] IDLE: Disable F5, etc, in Shell and Output windows.

Change by Terry J. Reedy : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ __

[issue38598] IDLE: Disable F5, etc, in Shell and Output windows.

miss-islington added the comment: New changeset e3a477aa072a737d5119b0778d14d9f3ddb9f587 by Miss Skeleton (bot) in branch '3.8': bpo-38598: Do not try to compile IDLE shell or output windows (GH-16939) https://github.com/python/cpython/commit/e3a477aa072a737d5119b0778d14d9f3ddb9f587 ---

[issue38598] IDLE: Disable F5, etc, in Shell and Output windows.

miss-islington added the comment: New changeset 849b1b9f6c538085839f8059e0d6a5536d2fdb52 by Miss Skeleton (bot) in branch '3.7': bpo-38598: Do not try to compile IDLE shell or output windows (GH-16939) https://github.com/python/cpython/commit/849b1b9f6c538085839f8059e0d6a5536d2fdb52 ---

[issue38598] IDLE: Disable F5, etc, in Shell and Output windows.

Change by miss-islington : -- pull_requests: +16471 pull_request: https://github.com/python/cpython/pull/16942 ___ Python tracker ___ __

[issue38598] IDLE: Disable F5, etc, in Shell and Output windows.

Terry J. Reedy added the comment: New changeset e3f90b217a5152275b180b466bd503658a734462 by Terry Jan Reedy in branch 'master': bpo-38598: Do not try to compile IDLE shell or output windows (GH-16939) https://github.com/python/cpython/commit/e3f90b217a5152275b180b466bd503658a734462

[issue38598] IDLE: Disable F5, etc, in Shell and Output windows.

Change by miss-islington : -- pull_requests: +16470 pull_request: https://github.com/python/cpython/pull/16941 ___ Python tracker ___ __

[issue38598] IDLE: Disable F5, etc, in Shell and Output windows.

Change by Terry J. Reedy : -- keywords: +patch pull_requests: +16468 stage: needs patch -> patch review pull_request: https://github.com/python/cpython/pull/16939 ___ Python tracker __

[issue38598] IDLE: Disable F5, etc, in Shell and Output windows.

Terry J. Reedy added the comment: Trying to compile grep output is also bad. The ultimate fix is to subclass the specialized code editor from the general text editor, instead of vice versa as at present, but I leave that for later, and will simply check if the window about to be compiled is