[issue38669] patch.object should raise another error when first argument is a str

2019-12-08 Thread Chris Withers
Change by Chris Withers : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue38669] patch.object should raise another error when first argument is a str

2019-12-08 Thread Chris Withers
Chris Withers added the comment: New changeset 41973c99fdfdc78315e819661e279bdcc2f058b1 by Chris Withers (Miss Islington (bot)) in branch '3.7': bpo-38669: patch.object now raises a helpful error (GH17511) https://github.com/python/cpython/commit/41973c99fdfdc78315e819661e279bdcc2f058b1

[issue38669] patch.object should raise another error when first argument is a str

2019-12-08 Thread Chris Withers
Chris Withers added the comment: New changeset 4594565b56e9c99d2d3fb7549041bbca5ecba8e2 by Chris Withers (Miss Islington (bot)) in branch '3.8': bpo-38669: patch.object now raises a helpful error (GH17510) https://github.com/python/cpython/commit/4594565b56e9c99d2d3fb7549041bbca5ecba8e2

[issue38669] patch.object should raise another error when first argument is a str

2019-12-08 Thread miss-islington
Change by miss-islington : -- pull_requests: +16987 pull_request: https://github.com/python/cpython/pull/17511 ___ Python tracker ___

[issue38669] patch.object should raise another error when first argument is a str

2019-12-08 Thread miss-islington
Change by miss-islington : -- pull_requests: +16986 pull_request: https://github.com/python/cpython/pull/17510 ___ Python tracker ___

[issue38669] patch.object should raise another error when first argument is a str

2019-12-08 Thread Chris Withers
Chris Withers added the comment: New changeset cd90a52983db34896a6335a572d55bdda274778f by Chris Withers (Elena Oat) in branch 'master': bpo-38669: patch.object now raises a helpful error (GH17034) https://github.com/python/cpython/commit/cd90a52983db34896a6335a572d55bdda274778f --

[issue38669] patch.object should raise another error when first argument is a str

2019-11-08 Thread Terry J. Reedy
Terry J. Reedy added the comment: This enhancement request (no backports) is about the unittest.mock patch.object. https://docs.python.org/3/library/unittest.mock.html#unittest.mock.patch.object -- nosy: +terry.reedy type: -> enhancement versions: -Python 3.5, Python 3.6, Python

[issue38669] patch.object should raise another error when first argument is a str

2019-11-03 Thread Elena Oat
Change by Elena Oat : -- keywords: +patch pull_requests: +16549 stage: -> patch review pull_request: https://github.com/python/cpython/pull/17034 ___ Python tracker ___

[issue38669] patch.object should raise another error when first argument is a str

2019-11-02 Thread Karthikeyan Singaravelan
Change by Karthikeyan Singaravelan : -- nosy: +cjw296, lisroach, mariocj89, michael.foord, xtreak ___ Python tracker ___ ___

[issue38669] patch.object should raise another error when first argument is a str

2019-11-02 Thread Elena Oat
New submission from Elena Oat : When using patch.object with first argument as a string, e.g. ´´patch.object('SomeClass', 'somemethod')´´ this raises ´´AttributeError: Something does not have the attribute 'do_something'´´. This should instead warn user that the correct type for the first