[issue38862] IDLE: Include end newlines in whitespace fix.

Change by Terry J. Reedy : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ __

[issue38862] IDLE: Include end newlines in whitespace fix.

Terry J. Reedy added the comment: New changeset 2fb971940b18bcf5a58b1b242b697d0f1d8ad7ef by Terry Jan Reedy in branch '3.7': [3.7] bpo-38862: IDLE Strip Trailing Whitespace fixes end newlines (GH-17366) (#17379) https://github.com/python/cpython/commit/2fb971940b18bcf5a58b1b242b697d0f1d8ad7

[issue38862] IDLE: Include end newlines in whitespace fix.

Terry J. Reedy added the comment: New changeset a9c86f5e1afa2487524b1947153953b583714d62 by Terry Jan Reedy in branch '3.8': [3.8] bpo-38862: IDLE Strip Trailing Whitespace fixes end newlines (GH-17366) https://github.com/python/cpython/commit/a9c86f5e1afa2487524b1947153953b583714d62 -

[issue38862] IDLE: Include end newlines in whitespace fix.

Change by Terry J. Reedy : -- pull_requests: +16862 pull_request: https://github.com/python/cpython/pull/17380 ___ Python tracker ___ __

[issue38862] IDLE: Include end newlines in whitespace fix.

Change by Terry J. Reedy : -- pull_requests: +16861 pull_request: https://github.com/python/cpython/pull/17379 ___ Python tracker ___ __

[issue38862] IDLE: Include end newlines in whitespace fix.

Terry J. Reedy added the comment: New changeset 6bf644ec82f14cceae68278dc35bafb00875efae by Terry Jan Reedy in branch 'master': bpo-38862: IDLE Strip Trailing Whitespace fixes end newlines (GH-17366) https://github.com/python/cpython/commit/6bf644ec82f14cceae68278dc35bafb00875efae ---

[issue38862] IDLE: Include end newlines in whitespace fix.

Change by miss-islington : -- pull_requests: +16855 pull_request: https://github.com/python/cpython/pull/17371 ___ Python tracker ___ __

[issue38862] IDLE: Include end newlines in whitespace fix.

Change by miss-islington : -- pull_requests: +16854 pull_request: https://github.com/python/cpython/pull/17370 ___ Python tracker ___ __

[issue38862] IDLE: Include end newlines in whitespace fix.

Terry J. Reedy added the comment: Currently, iomenu.IOBinding.fixnewlines makes sure that when a non-empty non-Shell file is saved (and possibly run), it ends with at least 1 newline. At one time, I believe, compile needed this, and it is still good practice. (Git diffs note the absence of

[issue38862] IDLE: Include end newlines in whitespace fix.

Terry J. Reedy added the comment: patchcheck.py removes even a single newline if that is all that remains after stripping each line. So the revised rule is that a file should be either empty or end with a non-whitespace followed by a newline. My intent is that a file be ready to merge to o

[issue38862] IDLE: Include end newlines in whitespace fix.

Change by Terry J. Reedy : -- keywords: +patch pull_requests: +16851 stage: test needed -> patch review pull_request: https://github.com/python/cpython/pull/17366 ___ Python tracker __

[issue38862] IDLE: Include end newlines in whitespace fix.

Change by Terry J. Reedy : -- title: IDLE: Include end whitespace in whitespace fix. -> IDLE: Include end newlines in whitespace fix. ___ Python tracker ___ __