[issue39016] Negative Refcount in Python 3.8

2019-12-11 Thread Christian Tismer
Change by Christian Tismer : -- resolution: -> not a bug status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailing

[issue39016] Negative Refcount in Python 3.8

2019-12-11 Thread Christian Tismer
Change by Christian Tismer : -- stage: patch review -> resolved ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe

[issue39016] Negative Refcount in Python 3.8

2019-12-11 Thread Christian Tismer
Christian Tismer added the comment: Sorry, I believe I was wrong and lookup_maybe_method does not return a borrowed reference. _PyType_Lookup does and I was confused. Closing that for now. -- ___ Python tracker

[issue39016] Negative Refcount in Python 3.8

2019-12-11 Thread Petr Viktorin
Petr Viktorin added the comment: Thanks! (note: unfortunately I'll probably not have time for CPython until next week, but further investigation is on my list.) -- ___ Python tracker __

[issue39016] Negative Refcount in Python 3.8

2019-12-11 Thread Christian Tismer
Christian Tismer added the comment: On 11.12.19 17:37, Petr Viktorin wrote: > > Petr Viktorin added the comment: > > The goal now should be to find a reasonably small reproducer. > > I'm trying to compile PySide to see what it does, but it's a big project and > I'm a bit lost. > Christian,

[issue39016] Negative Refcount in Python 3.8

2019-12-11 Thread Petr Viktorin
Petr Viktorin added the comment: The goal now should be to find a reasonably small reproducer. I'm trying to compile PySide to see what it does, but it's a big project and I'm a bit lost. Christian, you said in an e-mail that you have a workaround -- unsetting the Py_TPFLAGS_METHOD_DESCRIPTO

[issue39016] Negative Refcount in Python 3.8

2019-12-11 Thread Christian Tismer
Christian Tismer added the comment: On 11.12.19 14:13, Petr Viktorin wrote: > > Petr Viktorin added the comment: > > lookup_maybe_method should not return a borrowed reference. It increfs its > return value. At second sight, this seems to be true. No idea why I was so convinced. Need to sl

[issue39016] Negative Refcount in Python 3.8

2019-12-11 Thread Petr Viktorin
Petr Viktorin added the comment: lookup_maybe_method should not return a borrowed reference. It increfs its return value. -- nosy: +petr.viktorin ___ Python tracker ___ _

[issue39016] Negative Refcount in Python 3.8

2019-12-10 Thread Christian Tismer
Christian Tismer added the comment: On 10.12.19 17:57, Pablo Galindo Salgado wrote: > > Pablo Galindo Salgado added the comment: > >> No, this appears to be impossible. > > Oh, I see. Apologies then for the misunderstunding. No problem! You could as well have been right. I tried to move th

[issue39016] Negative Refcount in Python 3.8

2019-12-10 Thread Christian Tismer
Christian Tismer added the comment: On 10.12.19 17:57, Pablo Galindo Salgado wrote: > > Pablo Galindo Salgado added the comment: > >> No, this appears to be impossible. > > Oh, I see. Apologies then for the misunderstunding. Well, but I think that is weird, too! Why should that custom clau

[issue39016] Negative Refcount in Python 3.8

2019-12-10 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: > No, this appears to be impossible. Oh, I see. Apologies then for the misunderstunding. -- ___ Python tracker ___ __

[issue39016] Negative Refcount in Python 3.8

2019-12-10 Thread Christian Tismer
Christian Tismer added the comment: No, this appears to be impossible. The function "type_mro_modified" exists as well, but there is no "if (custom) {" branch at all! On 10.12.19 17:21, Pablo Galindo Salgado wrote: > > Pablo Galindo Salgado added the comment: > >>From the PR: > > Christia

[issue39016] Negative Refcount in Python 3.8

2019-12-10 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: >From the PR: Christian, can you open the PR against master instead? We will backport the change to 3.8 after is merged. -- nosy: +pablogsal ___ Python tracker

[issue39016] Negative Refcount in Python 3.8

2019-12-10 Thread Christian Tismer
New submission from Christian Tismer : By the new Py_TPFLAGS_METHOD_DESCRIPTOR flag, a new code path is activated, and when extension types like PySide create a new class, we observe negative refcounts. The reason is that the code in typeobject.c fkt. type_mro_modified calls lookup_maybe_method

[issue39016] Negative Refcount in Python 3.8

2019-12-10 Thread Christian Tismer
Change by Christian Tismer : -- keywords: +patch pull_requests: +17029 stage: -> patch review pull_request: https://github.com/python/cpython/pull/17555 ___ Python tracker ___