[issue39026] pystate.h contains non-relative of initconfig.h include causing macOS Framework include failure

Change by STINNER Victor : -- pull_requests: +26982 pull_request: https://github.com/python/cpython/pull/28612 ___ Python tracker ___

[issue39026] pystate.h contains non-relative of initconfig.h include causing macOS Framework include failure

STINNER Victor added the comment: I marked bpo-40642 as a duplicate of this issue. -- ___ Python tracker ___ ___ Python-bugs-list

[issue39026] pystate.h contains non-relative of initconfig.h include causing macOS Framework include failure

STINNER Victor added the comment: > 2. Remove cpython/initconfig.h from cpython/pystate.h Let's start with that and see if it's enough to fix the issue. -- ___ Python tracker

[issue39026] pystate.h contains non-relative of initconfig.h include causing macOS Framework include failure

Kevin Mooney added the comment: Ok, so there are three potential solutions 1. Add cpython_ prefix to cpython headers 2. Remove cpython/initconfig.h from cpython/pystate.h 3. Include initconfig.h rather than cpython/initconfig.h 1 intoduces verbosity and touches more than the other solutions.

[issue39026] pystate.h contains non-relative of initconfig.h include causing macOS Framework include failure

STINNER Victor added the comment: I propose to rename "cpython/initconfig.h" to "cpython/cpython_initconfig.h". #include "cpython/initconfig.h" would become: #include "cpython/cpython_initconfig.h" So it becomes possible to include a cpython_xxx.h header from another cpython_xxx.h header

[issue39026] pystate.h contains non-relative of initconfig.h include causing macOS Framework include failure

Kevin Mooney added the comment: Ok, I think I see. Is there a concern that removing the cpython/ prefix might lead to the wrong initconfig.h being included? So your proposal is all includes in the root will do #include "cpython/cpython_foo.h" And any includes done in the cpython dir

[issue39026] pystate.h contains non-relative of initconfig.h include causing macOS Framework include failure

STINNER Victor added the comment: IMO a better approach would be to add "cpython_" prefix to all header files living in Include/cpython/. It would prevent bad surprises. I tried to avoid adding a prefix when I added Include/internal/ but I got many practical issues. Depending where the

[issue39026] pystate.h contains non-relative of initconfig.h include causing macOS Framework include failure

Change by Kevin Mooney : -- keywords: +patch nosy: +Kevin Mooney nosy_count: 5.0 -> 6.0 pull_requests: +19482 stage: -> patch review pull_request: https://github.com/python/cpython/pull/20181 ___ Python tracker

[issue39026] pystate.h contains non-relative of initconfig.h include causing macOS Framework include failure

Change by Matej Cepl : -- nosy: +mcepl ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue39026] pystate.h contains non-relative of initconfig.h include causing macOS Framework include failure

Gaige Paulsen added the comment: I should have been more specific. Sorry about that. Yes, when including in Xcode, incorporating the framework. In particular, I'm embedding 3.8 in an application (previously used the system Framework, which was 2.7, which worked but Apple has warned that it

[issue39026] pystate.h contains non-relative of initconfig.h include causing macOS Framework include failure

Ronald Oussoren added the comment: In what way does it not work when using a framework build? Is this when you add the python framework to an (Xcode) project and include the main python header using "#include "? -- ___ Python tracker

[issue39026] pystate.h contains non-relative of initconfig.h include causing macOS Framework include failure

New submission from Gaige Paulsen : The cpython/pystate.h includes cpython/initconfig.h using the relative path "cpython/initconfig.h", which probably works fine if your include path explicitly contains the top of the python directory, however when developing with a framework in macOS, the

[issue39026] pystate.h contains non-relative of initconfig.h include causing macOS Framework include failure

Change by STINNER Victor : -- nosy: +vstinner ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: