[issue39028] ENH: Fix performance issue in keyword extraction

Change by Inada Naoki : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: -Python 3.8 ___ Python tracker ___ __

[issue39028] ENH: Fix performance issue in keyword extraction

Inada Naoki added the comment: New changeset 75bb07e92baa7267a61056d03d7e6b475588e793 by Inada Naoki (Sebastian Berg) in branch 'master': bpo-39028: Performance enhancement in keyword extraction (GH-17576) https://github.com/python/cpython/commit/75bb07e92baa7267a61056d03d7e6b475588e793 ---

[issue39028] ENH: Fix performance issue in keyword extraction

Sebastian Berg added the comment: Fair enough, we had code that does it the other way, so it seemed "too obvious" since the current check seems mainly useful with few kwargs. However, a single kwarg is super common in python, while many seem super rare (in any argument clinic function) Whic

[issue39028] ENH: Fix performance issue in keyword extraction

Change by Pablo Galindo Salgado : -- nosy: +pablogsal ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https:/

[issue39028] ENH: Fix performance issue in keyword extraction

Change by Inada Naoki : -- nosy: +inada.naoki ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.py

[issue39028] ENH: Fix performance issue in keyword extraction

Serhiy Storchaka added the comment: Could you please provide benchmarks which demonstrate the performance issue? -- nosy: +serhiy.storchaka ___ Python tracker ___

[issue39028] ENH: Fix performance issue in keyword extraction

New submission from Sebastian Berg : The keyword argument extraction/finding function seems to have a performance bug/enhancement (unless I am missing something here). It reads: ``` for (i=0; i < nkwargs; i++) { PyObject *kwname = PyTuple_GET_ITEM(kwnames, i); /* ptr==ptr

[issue39028] ENH: Fix performance issue in keyword extraction

Change by Sebastian Berg : -- keywords: +patch pull_requests: +17049 stage: -> patch review pull_request: https://github.com/python/cpython/pull/17576 ___ Python tracker ___ _