[issue39153] Clarify refcounting semantics of PyDict_SetItem[String]

Dong-hee Na added the comment: @nanjekyejoannah Thanks for the update :) -- nosy: +corona10 resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue39153] Clarify refcounting semantics of PyDict_SetItem[String]

miss-islington added the comment: New changeset 526523c19322169a7f7507d9da291053df979412 by Miss Islington (bot) in branch '3.8': bpo-39153: Clarify C API *SetItem refcounting semantics (GH-18220) https://github.com/python/cpython/commit/526523c19322169a7f7507d9da291053df979412 --

[issue39153] Clarify refcounting semantics of PyDict_SetItem[String]

Nick Coghlan added the comment: New changeset e1e80002e28e1055f399a20918c49d50d093709e by Joannah Nanjekye in branch 'master': bpo-39153: Clarify C API *SetItem refcounting semantics (GH-18220) https://github.com/python/cpython/commit/e1e80002e28e1055f399a20918c49d50d093709e --

[issue39153] Clarify refcounting semantics of PyDict_SetItem[String]

Change by miss-islington : -- pull_requests: +17625 pull_request: https://github.com/python/cpython/pull/18246 ___ Python tracker ___

[issue39153] Clarify refcounting semantics of PyDict_SetItem[String]

Change by Joannah Nanjekye : -- keywords: +patch pull_requests: +17600 stage: needs patch -> patch review pull_request: https://github.com/python/cpython/pull/18220 ___ Python tracker

[issue39153] Clarify refcounting semantics of PyDict_SetItem[String]

Nick Coghlan added the comment: Right, that's why I don't think the other "*SetItem*" operations should get a Sphinx note - just a sentence, as was already done for PySequence_SetItem. If it weren't for PyList_SetItem being different, none of the others would need the clarification at all.

[issue39153] Clarify refcounting semantics of PyDict_SetItem[String]

Serhiy Storchaka added the comment: The documentation for PyList_SetItem is explicit because its behavior is an exception from common rule and differs from PyList_SET_ITEM, so both should be documented explicitly. -- nosy: +serhiy.storchaka ___

[issue39153] Clarify refcounting semantics of PyDict_SetItem[String]

Change by Nick Coghlan : -- assignee: -> docs@python components: +Documentation nosy: +docs@python stage: -> needs patch type: -> enhancement versions: +Python 3.8, Python 3.9 ___ Python tracker

[issue39153] Clarify refcounting semantics of PyDict_SetItem[String]

New submission from Nick Coghlan : The documentation for PyList_SetItem is explicit that it steals a reference to the passed in value, and drops the reference for any existing entry: https://docs.python.org/3.3/c-api/list.html?highlight=m#PyList_SetItem The documentation for PyDict_SetItem