Georg Brandl ge...@python.org added the comment:
Thanks for the patch! Applied in r81465 f. Merged to 2.x in r81467, will
merge to 3k later.
--
nosy: +georg.brandl
resolution: - fixed
status: open - closed
___
Python tracker
Changes by Andrew Shuiu as...@bitdefender.com:
--
versions: +Python 3.1
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue3924
___
___
Andy Sk python...@bitjug.com added the comment:
Thank you Henrik. The workaround in the first comment caused some
cookies to be handled incorrectly due to ignoring version on all
cookies, but your workaround is nice.
It seems that the patch jjlee supplied should really be applied,
however,
Henrik Olsson henr...@wip.se added the comment:
The cookiejar workaround in the first comment did not work for me. The
cookies didn't stick in it. I guess version needs to be set.. this
worked for me:
class ForgivingCookieJar(cookielib.CookieJar):
def _cookie_from_cookie_tuple(self, tup,
Changes by Daniel Diniz aja...@gmail.com:
--
stage: - patch review
versions: -Python 2.5
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue3924
___
Martin v. Löwis [EMAIL PROTECTED] added the comment:
As the patch hasn't been applied to the trunk yet, I'm rejecting it for
2.5.3.
--
nosy: +loewis
versions: -Python 2.5.3
___
Python tracker [EMAIL PROTECTED]
http://bugs.python.org/issue3924
John J Lee [EMAIL PROTECTED] added the comment:
Patch with tests attached. The patch is slightly different to my first
suggestion: in the patch, invalid version values cause the cookie to be
ignored (but double quotes around valid versions are fine).
--
keywords: +patch
Added file:
John J Lee [EMAIL PROTECTED] added the comment:
The bug is present on trunk and on the py3k branch, so I've selected
versions Python 2.7 and Python 3.0
This is a straightforward bug, so I selected 2.5.3 and 2.6 also, to
indicate this is a candidate for backport.
--
components: +Library
John J Lee [EMAIL PROTECTED] added the comment:
The sensible fix for this is to strip the quotes off, defaulting to
version 0 on failure to parse the version cookie-attribute. It's not
necessary to retain the original version string.
By the way, what you posted warning rather than a strictly
New submission from Denis [EMAIL PROTECTED]:
PROBLEM:
Some sites (e.g. https://itunesconnect.apple.com) sends cookies where
version is 1 instead of 1. Cookielib chokes on it so none of the
cookies work after that.
PROBLEM CODE:
def _cookie_from_cookie_tuple(self, tup, request):
...
10 matches
Mail list logo