[issue39372] The header files in Include/ have many declarations with no definition

STINNER Victor added the comment: > Maybe backport this change (except PyNoArgsFunction)? I don't think that it's a good idea. I suggest to only do cleanup in the master branch, just in case if something goes wrong. Like the PyNoArgsFunction removal :-) -- nosy: +vstinner

[issue39372] The header files in Include/ have many declarations with no definition

Petr Viktorin added the comment: Since the removal of PyNoArgsFunction breaks user code, does it deserve a mention in What's New – Porting to Python 3.9? -- nosy: +petr.viktorin ___ Python tracker

[issue39372] The header files in Include/ have many declarations with no definition

Pablo Galindo Salgado added the comment: > Maybe backport this change (except PyNoArgsFunction)? I didn't think of backporting to reduce the possibilities of something going wrong, but is true that a backport without PyNoArgsFunction should be harmless. Reopening the issue meanwhile I do on

[issue39372] The header files in Include/ have many declarations with no definition

Serhiy Storchaka added the comment: Maybe backport this change (except PyNoArgsFunction)? -- ___ Python tracker ___ ___

[issue39372] The header files in Include/ have many declarations with no definition

Zackery Spytz added the comment: The removal of PyNoArgsFunction is the subject of bpo-18091. -- nosy: +ZackerySpytz ___ Python tracker ___

[issue39372] The header files in Include/ have many declarations with no definition

Change by Pablo Galindo Salgado : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue39372] The header files in Include/ have many declarations with no definition

Pablo Galindo Salgado added the comment: New changeset cd7db76a636c218b2d81d3526eb435cfae61f212 by Pablo Galindo in branch 'master': bpo-39372: Clean header files of declared interfaces with no implementations (GH-18037)

[issue39372] The header files in Include/ have many declarations with no definition

Serhiy Storchaka added the comment: Good catch! All removals LGTM. -- nosy: +serhiy.storchaka ___ Python tracker ___ ___

[issue39372] The header files in Include/ have many declarations with no definition

Change by Pablo Galindo Salgado : -- keywords: +patch pull_requests: +17436 stage: -> patch review pull_request: https://github.com/python/cpython/pull/18037 ___ Python tracker

[issue39372] The header files in Include/ have many declarations with no definition

New submission from Pablo Galindo Salgado : There are many declarations that lack definitions in our header files that should be cleaned (linking against those symbols will fail so removing them should be safe if I am not missing something). -- components: Build messages: 360204