[issue39495] xml.etree.ElementTree.TreeBuilder.start differs between pure Python and C implementations

Change by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: +Python 3.9 ___ Python tracker ___

[issue39495] xml.etree.ElementTree.TreeBuilder.start differs between pure Python and C implementations

Serhiy Storchaka added the comment: New changeset 4edc95cf0a2960431621eee9bc194f6225f1690b by Shantanu in branch 'master': bpo-39495: Remove default value from C impl of TreeBuilder.start (GH-18275) https://github.com/python/cpython/commit/4edc95cf0a2960431621eee9bc194f6225f1690b

[issue39495] xml.etree.ElementTree.TreeBuilder.start differs between pure Python and C implementations

Change by Shantanu : -- keywords: +patch pull_requests: +17650 stage: -> patch review pull_request: https://github.com/python/cpython/pull/18275 ___ Python tracker ___

[issue39495] xml.etree.ElementTree.TreeBuilder.start differs between pure Python and C implementations

Serhiy Storchaka added the comment: According to the documentation the attrs parameter does not have default value. I think that the C implementation should be changed. https://docs.python.org/3/library/xml.etree.elementtree.html#xml.etree.ElementTree.TreeBuilder.start --

[issue39495] xml.etree.ElementTree.TreeBuilder.start differs between pure Python and C implementations

Shantanu added the comment: Based on https://github.com/python/cpython/blob/master/Modules/_elementtree.c#L2700 and the behaviour at runtime, something like the following patch could work: ``` diff --git a/Lib/xml/etree/ElementTree.py b/Lib/xml/etree/ElementTree.py index

[issue39495] xml.etree.ElementTree.TreeBuilder.start differs between pure Python and C implementations

Change by Karthikeyan Singaravelan : -- nosy: +eli.bendersky, scoder, serhiy.storchaka ___ Python tracker ___ ___ Python-bugs-list

[issue39495] xml.etree.ElementTree.TreeBuilder.start differs between pure Python and C implementations

New submission from Shantanu : The C accelerated version of `xml.etree.ElementTree.TreeBuilder.start` has a default value for `attrs`, whereas the pure Python version does not. ``` In [41]: sys.version