[issue39500] Document PyUnicode_IsIdentifier() function

STINNER Victor added the comment: New changeset 3d235f5c5c5bce6e0caec44d2ce17f670c2ca2d7 by Hai Shi in branch 'master': bpo-39500: Fix compile warnings in unicodeobject.c (GH-18519) https://github.com/python/cpython/commit/3d235f5c5c5bce6e0caec44d2ce17f670c2ca2d7 -- ___

[issue39500] Document PyUnicode_IsIdentifier() function

Change by STINNER Victor : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ __

[issue39500] Document PyUnicode_IsIdentifier() function

STINNER Victor added the comment: New changeset f3e7ea5b8c220cd63101e419d529c8563f9c6115 by Victor Stinner in branch 'master': bpo-39500: Document PyUnicode_IsIdentifier() function (GH-18397) https://github.com/python/cpython/commit/f3e7ea5b8c220cd63101e419d529c8563f9c6115 -- _

[issue39500] Document PyUnicode_IsIdentifier() function

Change by STINNER Victor : -- pull_requests: +17773 pull_request: https://github.com/python/cpython/pull/18397 ___ Python tracker ___ __

[issue39500] Document PyUnicode_IsIdentifier() function

Serhiy Storchaka added the comment: It is not convenient to check the result for error. After we remove support of old PyUnicode API, PyUnicode_IsIdentifier() will be always succeeded. Note that PyUnicode_IsIdentifier() still can crash if you pass a non-PyUnicode object or NULL. It is a prer

[issue39500] Document PyUnicode_IsIdentifier() function

STINNER Victor added the comment: > They are bad examples, but can't be changed for backward compatibility. I don't think that we should follow these bad examples :-) IMO ignoring silently bugs is a bad programming practice. I don't expect PyUnicode_IsIdentifier() to be used outside Python.

[issue39500] Document PyUnicode_IsIdentifier() function

Serhiy Storchaka added the comment: Other examples are: * PyObject_HasAttr * PyObject_HasAttrString * PyMapping_HasKey * PyMapping_HasKeyString They are bad examples, but can't be changed for backward compatibility. I wonder whether PyUnicode_IsIdentifier should also kept unchanged for backw

[issue39500] Document PyUnicode_IsIdentifier() function

STINNER Victor added the comment: > Since the behavior was changed, I think we need a versionchanged directive. Done. > But I am not sure that it could be triggered in real code without using some > broken extensions. _PyUnicode_Ready() can fail in two cases: the Py_UNICODE* string contain

[issue39500] Document PyUnicode_IsIdentifier() function

Serhiy Storchaka added the comment: Since the behavior was changed, I think we need a versionchanged directive. This function was added in 3.0. Prior to 3.3 it was always successful (if you pass an unicode object, that is required for most of PyUnicode API). Py_FatalError was added in 3.3, b

[issue39500] Document PyUnicode_IsIdentifier() function

Change by STINNER Victor : -- keywords: +patch pull_requests: +17655 stage: -> patch review pull_request: https://github.com/python/cpython/pull/18280 ___ Python tracker ___ _

[issue39500] Document PyUnicode_IsIdentifier() function

New submission from STINNER Victor : The PyUnicode_IsIdentifier() function should be documented. Attachd PR documents it. -- components: C API, Unicode messages: 361027 nosy: ezio.melotti, vstinner priority: normal severity: normal status: open title: Document PyUnicode_IsIdentifier()