[issue39590] collections.deque.__contains__ and .count should hold strong references.

2020-02-09 Thread Raymond Hettinger
Raymond Hettinger added the comment: New changeset dc56f5f48866bf3c5412642bba00890d9a090cfb by Miss Islington (bot) in branch '3.8': bpo-39590: make deque.__contains__ and deque.count hold strong references (GH-18421) (GH-18423) https://github.com/python/cpython/commit/dc56f5f48866bf3c541264

[issue39590] collections.deque.__contains__ and .count should hold strong references.

2020-02-09 Thread Raymond Hettinger
Change by Raymond Hettinger : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___

[issue39590] collections.deque.__contains__ and .count should hold strong references.

2020-02-09 Thread miss-islington
Change by miss-islington : -- pull_requests: +17800 pull_request: https://github.com/python/cpython/pull/18423 ___ Python tracker ___ __

[issue39590] collections.deque.__contains__ and .count should hold strong references.

2020-02-09 Thread Raymond Hettinger
Raymond Hettinger added the comment: New changeset c6dedde160a9fce5d049e860f586ad8f93aec822 by sweeneyde in branch 'master': bpo-39590: make deque.__contains__ and deque.count hold strong references (GH-18421) https://github.com/python/cpython/commit/c6dedde160a9fce5d049e860f586ad8f93aec822

[issue39590] collections.deque.__contains__ and .count should hold strong references.

2020-02-08 Thread Dennis Sweeney
Dennis Sweeney added the comment: Should there be a similar generic test case in test.seq_test? -- ___ Python tracker ___ ___ Pytho

[issue39590] collections.deque.__contains__ and .count should hold strong references.

2020-02-08 Thread Dennis Sweeney
Change by Dennis Sweeney : -- keywords: +patch pull_requests: +17796 stage: -> patch review pull_request: https://github.com/python/cpython/pull/18421 ___ Python tracker ___ _

[issue39590] collections.deque.__contains__ and .count should hold strong references.

2020-02-08 Thread Dennis Sweeney
New submission from Dennis Sweeney : Similar to https://bugs.python.org/issue39453, but with deques: Python 3.9.0a3+: >>> from collections import deque >>> class A: ... def __eq__(self, other): ... L.clear() ... return NotImplemented ... >>> L = [A(), A(), A()] >>> 17 in L