[issue39609] Set the thread_name_prefix for asyncio's default executor ThreadPoolExecutor

Change by Andrew Svetlov : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue39609] Set the thread_name_prefix for asyncio's default executor ThreadPoolExecutor

miss-islington added the comment: New changeset 374d998b507d34a6c0a3816a163926a8ba0c483f by Markus Mohrhard in branch 'master': bpo-39609: set the thread_name_prefix for the default asyncio executor (GH-18458) https://github.com/python/cpython/commit/374d998b507d34a6c0a3816a163926a8ba0c483f

[issue39609] Set the thread_name_prefix for asyncio's default executor ThreadPoolExecutor

Markus Mohrhard added the comment: We have by now changed to a custom executor. Asyncio is used in some of our dependencies and therefore it took some work to figure out what is creating the thousands of threads that we were seeing. This patch was part of the debuggin and we thought it

[issue39609] Set the thread_name_prefix for asyncio's default executor ThreadPoolExecutor

Caleb Hattingh added the comment: This change seems fine. Markus, I'm curious if there is a specific reason you prefer to use the default executor rather than replacing it with your own? Is it just convenience or are there other reasons? -- nosy: +cjrh

[issue39609] Set the thread_name_prefix for asyncio's default executor ThreadPoolExecutor

Change by Markus Mohrhard : -- keywords: +patch pull_requests: +17832 stage: -> patch review pull_request: https://github.com/python/cpython/pull/18458 ___ Python tracker ___

[issue39609] Set the thread_name_prefix for asyncio's default executor ThreadPoolExecutor

New submission from Markus Mohrhard : The ThreadPoolExecutor in BaseEventLoop.run_in_executor should set a thread_name_prefix to simplify debugging. Might also be worth to limit the number of max threads. On our 256 core machines we sometimes get 1000+ threads due to the cpu_count() * 5