[issue39652] sqlite3 bug handling column names that contain square braces

Change by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: +Python 3.7, Python 3.8 ___ Python tracker ___

[issue39652] sqlite3 bug handling column names that contain square braces

Serhiy Storchaka added the comment: New changeset 39680fb7043e555469e08d3c4f49073acca77b20 by Serhiy Storchaka in branch '3.7': [3.7] bpo-39652: Truncate the column name after '[' only if PARSE_COLNAMES is set. (GH-18942). (GH-19104)

[issue39652] sqlite3 bug handling column names that contain square braces

miss-islington added the comment: New changeset 687f5921a46cf95c2a648d8031f9e99cdcc3e6b7 by Miss Islington (bot) in branch '3.8': bpo-39652: Truncate the column name after '[' only if PARSE_COLNAMES is set. (GH-18942)

[issue39652] sqlite3 bug handling column names that contain square braces

Change by Serhiy Storchaka : -- pull_requests: +18464 pull_request: https://github.com/python/cpython/pull/19104 ___ Python tracker ___

[issue39652] sqlite3 bug handling column names that contain square braces

Change by miss-islington : -- nosy: +miss-islington nosy_count: 5.0 -> 6.0 pull_requests: +18463 pull_request: https://github.com/python/cpython/pull/19103 ___ Python tracker

[issue39652] sqlite3 bug handling column names that contain square braces

Serhiy Storchaka added the comment: New changeset b146568dfcbcd7409c724f8917e4f77433dd56e4 by Serhiy Storchaka in branch 'master': bpo-39652: Truncate the column name after '[' only if PARSE_COLNAMES is set. (GH-18942)

[issue39652] sqlite3 bug handling column names that contain square braces

Serhiy Storchaka added the comment: Sorry Raul, but I already have a PR written. It includes minor refactoring, better error handling in the nearby code, improved tests, fixed documentation and comments which incorrectly described the current behavior. It took time to determine what parts

[issue39652] sqlite3 bug handling column names that contain square braces

Change by Serhiy Storchaka : -- pull_requests: +18295 pull_request: https://github.com/python/cpython/pull/18942 ___ Python tracker ___

[issue39652] sqlite3 bug handling column names that contain square braces

Raul Gallegos added the comment: hi @serhiy.storchaka is this something that you think could be done by a new contributor? I'd really love to take care of this, I can improve on the PR I was preparing https://github.com/python/cpython/pull/18533 --

[issue39652] sqlite3 bug handling column names that contain square braces

Serhiy Storchaka added the comment: It was originally introduced in https://github.com/ghaering/pysqlite/commit/780a76dcd8f4142b6ecbd423f52e0ccf067fc277. I think that original column names should be returned when PARSE_COLNAMES is not set. Working on a PR. -- assignee: ->

[issue39652] sqlite3 bug handling column names that contain square braces

Berker Peksag added the comment: https://github.com/ghaering/pysqlite/commit/f3d452f2daeb432b8ad89fa4f087164bfd6ddc12 should probably give more context than that huge svnmerge commit :) (Removed older Python versions since even if decide to change the behavior from 2006, it may break

[issue39652] sqlite3 bug handling column names that contain square braces

Change by Karthikeyan Singaravelan : -- nosy: +berker.peksag, ghaering ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue39652] sqlite3 bug handling column names that contain square braces

Simon Willison added the comment: Oh how interesting - yes it looks like this is deliberate behavior introduced in this commit: https://github.com/python/cpython/commit/0e3f591aeeef9ed715f8770320f4c4c7332a8794 -- ___ Python tracker

[issue39652] sqlite3 bug handling column names that contain square braces

Raul Gallegos added the comment: Thanks for reporting this issue, I have a PR here https://github.com/python/cpython/pull/18533 but that still needs some clarification, because there were some tests that were actually testing that we were stripping everything after the square brackets.

[issue39652] sqlite3 bug handling column names that contain square braces

Change by Roundup Robot : -- keywords: +patch pull_requests: +17908 stage: -> patch review pull_request: https://github.com/python/cpython/pull/18533 ___ Python tracker ___

[issue39652] sqlite3 bug handling column names that contain square braces

Change by Simon Willison : -- type: -> behavior ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue39652] sqlite3 bug handling column names that contain square braces

New submission from Simon Willison : Bit of an obscure bug this one. SQLite allows column names to contain [ and ] characters, even though those are often used as delimiters in SQLite. Here's how to create such a database with bash: ``` sqlite3 /tmp/demo.db < In [5]: cursor.fetchall()