[issue39685] Python 3.8 regression Socket operation on non-socket

Change by Christian Heimes : -- resolution: -> third party stage: -> resolved status: open -> closed type: -> behavior ___ Python tracker ___ ___

[issue39685] Python 3.8 regression Socket operation on non-socket

Brian May added the comment: Consensus seems to be that this is a bug in sshuttle, not a bug in python. Thanks for the feedback. I think this bug can be closed now... -- ___ Python tracker

[issue39685] Python 3.8 regression Socket operation on non-socket

Christian Heimes added the comment: I don't consider this a regression. socket.fromfd() and socket(fd) never supported non-socket fds. It just happens to work in some cases by chance. It looks like sshuttle got lucky in the past. It never called a function that ultimately requires a socket f

[issue39685] Python 3.8 regression Socket operation on non-socket

Dima Tisnek added the comment: The code in question is interesting... I don't claim to understand it. A pair of file descriptors is passed wrapped in sockets, and the objects are used here: https://github.com/sshuttle/sshuttle/blob/966fd0c5231d56c4f464752865d96f97bd3c0aac/sshuttle/ssnet.py#L2

[issue39685] Python 3.8 regression Socket operation on non-socket

hillpd added the comment: Blocking the use of stdin/stdout like this looks intentional. I have added dimaqq and asvetlov for comment. The python docs [0] indicate that the file descriptor should be a socket: "The file descriptor should refer to a socket, but this is not checked — subsequent o

[issue39685] Python 3.8 regression Socket operation on non-socket

New submission from Brian May : After upgrading to Python 3.8, users of sshuttle report seeing this error: Traceback (most recent call last): File "", line 1, in File "assembler.py", line 38, in File "sshuttle.server", line 298, in main File "/usr/lib/python3.8/socket.py", line 544, i