[issue39797] shutdown() in socketserver.BaseServer should be in a different thread from serve_forever()

Ned Deily added the comment: Thank you for your PR! -- nosy: +ned.deily resolution: -> fixed stage: patch review -> resolved status: open -> closed type: enhancement -> versions: -Python 3.5, Python 3.6 ___ Python tracker

[issue39797] shutdown() in socketserver.BaseServer should be in a different thread from serve_forever()

miss-islington added the comment: New changeset 64937d308c71a5c95627b0a0d0574d164c0cf30a by Miss Islington (bot) in branch '3.7': bpo-39797 Changes to socketserver.BaseServer's shutdown() method. (GH-18929) https://github.com/python/cpython/commit/64937d308c71a5c95627b0a0d0574d164c0cf30a --

[issue39797] shutdown() in socketserver.BaseServer should be in a different thread from serve_forever()

miss-islington added the comment: New changeset 29723368e797f36ba8940f25b6e677852b7313b2 by Miss Islington (bot) in branch '3.8': bpo-39797 Changes to socketserver.BaseServer's shutdown() method. (GH-18929) https://github.com/python/cpython/commit/29723368e797f36ba8940f25b6e677852b7313b2 --

[issue39797] shutdown() in socketserver.BaseServer should be in a different thread from serve_forever()

Change by miss-islington : -- pull_requests: +18445 pull_request: https://github.com/python/cpython/pull/19085 ___ Python tracker ___ __

[issue39797] shutdown() in socketserver.BaseServer should be in a different thread from serve_forever()

Change by miss-islington : -- pull_requests: +18446 pull_request: https://github.com/python/cpython/pull/19086 ___ Python tracker ___ __

[issue39797] shutdown() in socketserver.BaseServer should be in a different thread from serve_forever()

miss-islington added the comment: New changeset 2de7ac97981c30e9c1001b05a771f52a41772c54 by amaajemyfren in branch 'master': bpo-39797 Changes to socketserver.BaseServer's shutdown() method. (GH-18929) https://github.com/python/cpython/commit/2de7ac97981c30e9c1001b05a771f52a41772c54 ---

[issue39797] shutdown() in socketserver.BaseServer should be in a different thread from serve_forever()

Change by Ama Aje My Fren : -- pull_requests: +18285 pull_request: https://github.com/python/cpython/pull/18933 ___ Python tracker ___ _

[issue39797] shutdown() in socketserver.BaseServer should be in a different thread from serve_forever()

Change by Ama Aje My Fren : -- pull_requests: +18284 pull_request: https://github.com/python/cpython/pull/18932 ___ Python tracker ___ _

[issue39797] shutdown() in socketserver.BaseServer should be in a different thread from serve_forever()

Change by Ama Aje My Fren : -- pull_requests: +18282 pull_request: https://github.com/python/cpython/pull/18930 ___ Python tracker ___ _

[issue39797] shutdown() in socketserver.BaseServer should be in a different thread from serve_forever()

Change by Ama Aje My Fren : -- pull_requests: +18281 pull_request: https://github.com/python/cpython/pull/18929 ___ Python tracker ___ _

[issue39797] shutdown() in socketserver.BaseServer should be in a different thread from serve_forever()

Change by Ama Aje My Fren : -- keywords: +patch pull_requests: +18278 stage: -> patch review pull_request: https://github.com/python/cpython/pull/18926 ___ Python tracker ___

[issue39797] shutdown() in socketserver.BaseServer should be in a different thread from serve_forever()

New submission from Ama Aje My Fren : When a subclass of socketserver.BaseServer is running after calling serve_forever() and needs to be shutdown, it may be shut down by sending a [shutdown()](https://docs.python.org/3/library/socketserver.html#socketserver.BaseServer.shutdown). The thing is