[issue3992] removed custom log from distutils

Changes by Éric Araujo mer...@netwok.org: -- nosy: +merwok ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue3992 ___ ___ Python-bugs-list mailing

[issue3992] removed custom log from distutils

Antonio Cavallo a.cava...@cavallinux.eu added the comment: Hi, the latest patch (custom-log.diff minus the import logging at the begin) breaks the imaging python module build: the log is in the file susebuild.failed.imaging.log. -- Added file:

[issue3992] removed custom log from distutils

Antonio Cavallo a.cava...@cavallinux.eu added the comment: Hi Tarek, there is a colliding warn symbol: one defiend whiting import warnings as warn and another defined as warn = logger.warn (~ line 56). It breaks all the modules build (see attached file susebuild.failed.imaging-2.log). As

[issue3992] removed custom log from distutils

Tarek Ziadé ziade.ta...@gmail.com added the comment: Antonio, I am starting to think that having distutils dependencies in site.py smells bad. I have sent a mail in python-dev about it, that is now discussed in python-ideas to discuss the creation of a separated sysconfig module. So this patch

[issue3992] removed custom log from distutils

Antonio Cavallo a.cava...@cavallinux.eu added the comment: Hi Tarek, This is the latest patch to log.py that compiles with the latest python svn 72494. It shows no problem with the few modules I've used so far: now I can't decide if this should go mainline or not but I'll leave here as

[issue3992] removed custom log from distutils

Antonio Cavallo a.cava...@cavallinux.eu added the comment: Actually I think the problem (see the attached file susebuild.log) is in the module time.so: during the build the python interpreter has not access to it (it is dynamically loaded) and it fails. If that works is because an already

[issue3992] removed custom log from distutils

Tarek Ziadé ziade.ta...@gmail.com added the comment: I still don't see the need to : - rename Log to Logger - remove DEBUG, INFO, WARN, ERROR, FATAL from the module In the next version of python we will have to keep them in any case and add a deprecation warning because third party tools

[issue3992] removed custom log from distutils

Antonio Cavallo a.cava...@cavallinux.eu added the comment: Hi Tarek, there is a new patch. - Logger is now back to Log - put back INFO/DEBUG etc. - Wrapped the code inside a try/except I removed the _global_logger/logger variables, because they're superfluous: so the cound of the

[issue3992] removed custom log from distutils

Changes by Antonio Cavallo a.cava...@cavallinux.eu: Removed file: http://bugs.python.org/file13908/issue3992.remove-custom-log.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue3992 ___

[issue3992] removed custom log from distutils

Changes by Tarek Ziadé ziade.ta...@gmail.com: Removed file: http://bugs.python.org/file11650/remove-custom-log.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue3992 ___

[issue3992] removed custom log from distutils

Changes by Tarek Ziadé ziade.ta...@gmail.com: Removed file: http://bugs.python.org/file13260/remove-custom-log-revised.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue3992 ___

[issue3992] removed custom log from distutils

Tarek Ziadé ziade.ta...@gmail.com added the comment: I removed the _global_logger/logger variables, because they're superfluous Yes but by adding log instead, and removing log = _global_log.log you are breaking Distutils because its uses log.log Besides, the rest seem OK. I'll work on your

[issue3992] removed custom log from distutils

Tarek Ziadé ziade.ta...@gmail.com added the comment: I have reworked your patch a little bit so it works for Distutils. But I still need to digg on the initialization problem to see if we can get rid of the problem : the new logging will not get imported as well during tests so it is not what

[issue3992] removed custom log from distutils

Tarek Ziadé ziade.ta...@gmail.com added the comment: ok the problem occurs because site.py calls distutils.util.get_platform in addbuilddir. I'll see what we can do in there. -- ___ Python tracker rep...@bugs.python.org

[issue3992] removed custom log from distutils

Antonio Cavallo a.cava...@cavallinux.eu added the comment: This patch changes the log.py in order to make use of the logging infrastructure. There are few point tough worth of mention. There're two separate stages when log.py is used: a) during the python interpreter build (let's call it

[issue3992] removed custom log from distutils

Tarek Ziadé ziade.ta...@gmail.com added the comment: After more thinking, I think we can use a better strategy: - adding a deprecate warning inside the log module and keep the code as it is - set in the __init__ module the regular logger - change every call in distutils from the old log

[issue3992] removed custom log from distutils

Antonio Cavallo a.cava...@cavallinux.eu added the comment: Hi Tarek, I agree that a change in that module is risky but a warning won't solve the main problem in the long run: anyway I'm not able to comment about the best strategy. Now the access problem: If an import logging is put into the

[issue3992] removed custom log from distutils

Changes by Antonio Cavallo a.cava...@cavallinux.eu: Added file: http://bugs.python.org/file13908/issue3992.remove-custom-log.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue3992 ___

[issue3992] removed custom log from distutils

Changes by Antonio Cavallo a.cava...@cavallinux.eu: Removed file: http://bugs.python.org/file13906/issue3992.remove-custom-log.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue3992 ___

[issue3992] removed custom log from distutils

Akira Kitada akit...@gmail.com added the comment: I updated the patch. Mine only changes log.py. -- nosy: +akitada Added file: http://bugs.python.org/file13260/remove-custom-log-revised.diff ___ Python tracker rep...@bugs.python.org

[issue3992] removed custom log from distutils

Tarek Ziadé ziade.ta...@gmail.com added the comment: Right now Distutils has also two warn styles: - log.warn, that uses a pseudo-logging warning and push it to stdout depending on the treshold level - cmd.warn, that push the message directly to sys.stderr So this has to be changed as

[issue3992] removed custom log from distutils

Changes by Tarek Ziadé ziade.ta...@gmail.com: -- priority: - normal ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue3992 ___ ___ Python-bugs-list

[issue3992] removed custom log from distutils

Changes by Tarek Ziadé ziade.ta...@gmail.com: -- assignee: - tarek ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue3992 ___ ___ Python-bugs-list

[issue3992] removed custom log from distutils

Changes by Tarek Ziadé [EMAIL PROTECTED]: -- versions: +Python 2.7, Python 3.1 -Python 2.6 ___ Python tracker [EMAIL PROTECTED] http://bugs.python.org/issue3992 ___ ___

[issue3992] removed custom log from distutils

New submission from Tarek Ziadé [EMAIL PROTECTED]: This patch removes the custom log implementation from distutils. It keeps the compatibility with the previous logger and its specific CONSTANTE names. It add a sys.stdout stream handler so it produces the same output. It is based on logging

[issue3992] removed custom log from distutils

Christian Heimes [EMAIL PROTECTED] added the comment: Hey Tarek! I fear most of your revisions - including this - can make it into 2.6 and 3.0. Python 2.6 and 3.0 are now in maintenance mode. Your patch doesn't fall under the category bug fix. You have to target 2.7 and 3.1. -- nosy: