Amaury Forgeot d'Arc amaur...@gmail.com added the comment:
Yes, the correction went in r68678, r68700, r68734 and r68735
--
resolution: - fixed
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue3997
Changes by STINNER Victor victor.stin...@haypocalc.com:
Removed file: http://bugs.python.org/file11841/zip-64k.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue3997
___
Changes by STINNER Victor victor.stin...@haypocalc.com:
Removed file: http://bugs.python.org/file11850/zip-64k-2.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue3997
___
Brett Cannon br...@python.org added the comment:
Amaury, did the buildbots verify this worked and thus this bug can be
closed?
--
nosy: +brett.cannon
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue3997
Amaury Forgeot d'Arc amaur...@gmail.com added the comment:
Here is an updated version (zip-64k-3.patch).
Now the condition for writing a ZIP64 end-of-archive depends on the
size of all three values.
Added file: http://bugs.python.org/file12775/zip-64k-3.patch
Martin v. Löwis mar...@v.loewis.de added the comment:
Looks fine to me. Please apply.
--
keywords: -needs review
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue3997
___
Antoine Pitrou pit...@free.fr added the comment:
Reopening, some tests have started deterministically failing:
==
ERROR: testAbsoluteArcnames (test.test_zipfile.TestZip64InSmallFiles)
Changes by Amaury Forgeot d'Arc amaur...@gmail.com:
Added file: http://bugs.python.org/file12779/zip64-alwaystry2.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue3997
___
Amaury Forgeot d'Arc amaur...@gmail.com added the comment:
Applied the zip64-alwaystry2.patch in trunk, waiting for buildbots.
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue3997
___
Martin v. Löwis mar...@v.loewis.de added the comment:
The patch looks nearly fine. AFAICT, care must be taken to always write
a ZIP64 end-of-cd record whenever an end-of-cd field overflows; I think
this patch is missing the condition centDirSize ZIP64_LIMIT.
--
assignee: -
Changes by Martin v. Löwis mar...@v.loewis.de:
--
versions: +Python 2.7, Python 3.0, Python 3.1
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue3997
___
Changes by Martin v. Löwis mar...@v.loewis.de:
--
priority: - release blocker
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue3997
___
___
vali [EMAIL PROTECTED] added the comment:
I could verify that the patch works with both the Windows Compress
utility, WinZip and 7zip.
Thank you!
___
Python tracker [EMAIL PROTECTED]
http://bugs.python.org/issue3997
___
vali [EMAIL PROTECTED] added the comment:
Thank you for the quick fix. I could verify that the issue is fixed in
python 2.6 when I use WinZip to open an archive with more than 2^16
files created with attached script (bug.py). However the windows native
compress utility does not seem to be able
Amaury Forgeot d'Arc [EMAIL PROTECTED] added the comment:
OK, it seems that the central directory size and central directory
offset must contain their actual value if it can fit in a 32bit int,
even though the spec says If an archive is in ZIP64 format and the
value in this field is
vali [EMAIL PROTECTED] added the comment:
The version I used should not have this limitation as archives created
with other languages as Java or C# opens fine in WinZip 11.2 evaluation
version. Also the same issue can be observed in Windows compress utility.
Amaury Forgeot d'Arc [EMAIL PROTECTED] added the comment:
Right, this is a bug in zipfile.py.
The official PKZIP specifications says:
http://www.pkware.com/documents/casestudies/APPNOTE.TXT
total number of entries in the central dir: (2 bytes)
The total number of files in the
New submission from vali [EMAIL PROTECTED]:
using ZipFile library with Python 2.6 or an earlier version creates
archived files that are not compatible with windows compress or Winzip.
Other programs like 7-Zip will not have a problem with the format.
Bug Description:
if it is attempted to
Amaury Forgeot d'Arc [EMAIL PROTECTED] added the comment:
An archive with more than 65535 files must use the 64-bit extensions
of the standard Zip format.
Such archives cannot be opened by programs that do not understand these
extensions. See http://www.winzip.com/wzdic.htm
Which version of
19 matches
Mail list logo
