[issue40145] Pyshellext room for binary size improvement

Steve Dower added the comment: In general, no settings rely on both Platform AND Configuration, so you likely only need to check one or the other. Look at PCbuild/pyproject.props for the best examples. IIRC, properties are set assuming Win32/Release, and then we override those that need to

[issue40145] Pyshellext room for binary size improvement

Alexander Riccio added the comment: Oh, uh, also, do you prefer I add a commit or a new branch & PR? -- ___ Python tracker ___ ___

[issue40145] Pyshellext room for binary size improvement

Alexander Riccio added the comment: Ahh, ok. Even though I question the usefulness of manually maintaining MSBuild files instead of something like CMake, I can work with that. Is there a preferred way to do it? It looks like I can do a

[issue40145] Pyshellext room for binary size improvement

Steve Dower added the comment: I'm seeing some numbers that suggest it's even bigger than 7 million, so you might be deserving of more! Of course, that bandwidth is a donation, so you'll have to apply to Fastly ;) Our MSBuild projects are hand-maintained (often by people on non-Windows

[issue40145] Pyshellext room for binary size improvement

Change by Alexander Riccio : -- pull_requests: +18659 pull_request: https://github.com/python/cpython/pull/19298 ___ Python tracker ___

[issue40145] Pyshellext room for binary size improvement

Alexander Riccio added the comment: If this patch is merged, and all 7 million (estimated) Python developers update their installation, I calculate that I just saved the PSF 119GB worth of bandwidth costs :) I'll take my 10 cents in the mail please :D --

[issue40145] Pyshellext room for binary size improvement

Change by Alexander Riccio : -- keywords: +patch pull_requests: +18642 stage: -> patch review pull_request: https://github.com/python/cpython/pull/19284 ___ Python tracker

[issue40145] Pyshellext room for binary size improvement

New submission from Alexander Riccio : I've tweaked the pcbuild options for pyshellext to reduce the size of the binary. Since this is a very simple component, there really isn't much benefit of optimizing for speed, likely the slowest part of this component's lifetime is simply loading it.