[issue40423] Optimization: use close_range(2) if available

Gregory P. Smith added the comment: thanks Kyle! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue40423] Optimization: use close_range(2) if available

miss-islington added the comment: New changeset 1800c600801709958af66bebfa683a4e7570810f by Kyle Evans in branch 'master': bpo-40423: Optimization: use close_range(2) if available (GH-22651) https://github.com/python/cpython/commit/1800c600801709958af66bebfa683a4e7570810f -- nosy:

[issue40423] Optimization: use close_range(2) if available

Change by Gregory P. Smith : -- assignee: -> gregory.p.smith ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue40423] Optimization: use close_range(2) if available

Gregory P. Smith added the comment: Ah, yeah ENOSYS is it. I had to do this trick in older subprocess versions for something else. Still visible here in the old 2.7 backport: https://github.com/google/python-subprocess32/blob/main/_posixsubprocess.c#L801 --

[issue40423] Optimization: use close_range(2) if available

Change by Kyle Evans : -- pull_requests: +21624 stage: -> patch review pull_request: https://github.com/python/cpython/pull/22651 ___ Python tracker ___

[issue40423] Optimization: use close_range(2) if available

Kyle Evans added the comment: Ah, I will fix this and then submit a PR, thanks... hopefully it returns ENOSYS. -- nosy: +kevans ___ Python tracker ___

[issue40423] Optimization: use close_range(2) if available

Change by Gregory P. Smith : -- versions: +Python 3.10 -Python 3.9 ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue40423] Optimization: use close_range(2) if available

Gregory P. Smith added the comment: for reference, very recent Linux kernels appear to have gained a close_range syscall. http://lkml.iu.edu/hypermail/linux/kernel/2008.0/02649.html Your diff isn't quite sufficient as is. When depending on a syscall that has a function provided by libc,

[issue40423] Optimization: use close_range(2) if available

New submission from Kyle Evans : This is dependent on issue40422; the diff on top of that (PR19075) looks like the attached. Effectively, close_range(2) should be preferred at all times if it's available, otherwise we'll use closefrom(2) if available with a fallback to fdwalk(3) or plain old