[issue40501] Deprecate and remove ctypes usage in uuid

Steve Dower added the comment: New changeset d6b727e2c947240804b8e434b305ba2890122550 by Steve Dower in branch 'master': bpo-40501: Replace ctypes code in uuid with native module (GH-19948) https://github.com/python/cpython/commit/d6b727e2c947240804b8e434b305ba2890122550 --

[issue40501] Deprecate and remove ctypes usage in uuid

Steve Dower added the comment: Thanks Ned. There are some platform.version() checks in there that I'm basically ignoring right now - are those unnecessary? Shall I clean them up too? -- ___ Python tracker

[issue40501] Deprecate and remove ctypes usage in uuid

Ned Deily added the comment: > (A) Ensure that _uuid works on macOS, FreeBSD and Linux, especially in the > macOS installer of python.org. FWIW, a spot check shows that _uuid builds and test_uuid passes both sets of its tests, e.g. TestUUIDWithExtModule and TestUUIDWithoutExtModule, with

[issue40501] Deprecate and remove ctypes usage in uuid

Change by Steve Dower : -- keywords: +patch pull_requests: +19263 stage: test needed -> patch review pull_request: https://github.com/python/cpython/pull/19948 ___ Python tracker

[issue40501] Deprecate and remove ctypes usage in uuid

STINNER Victor added the comment: > Do you think either need a deprecation cycle? I'd say not for the Windows > change, but I'm not sure whether people could be relying on libuuid showing > up after build. If the behavior doesn't change, no deprecation is needed. For example, if libuuid

[issue40501] Deprecate and remove ctypes usage in uuid

Change by Dong-hee Na : -- nosy: +corona10 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue40501] Deprecate and remove ctypes usage in uuid

Steve Dower added the comment: Do you think either need a deprecation cycle? I'd say not for the Windows change, but I'm not sure whether people could be relying on libuuid showing up after build. -- ___ Python tracker

[issue40501] Deprecate and remove ctypes usage in uuid

STINNER Victor added the comment: uuid.py has a long history. The recent history is the addition of the _uuid module which exposes libuuid function properly. IMHO it's a better approach than ctypes. On Windows, it seems like ctypes remains used to get access to Windows function

[issue40501] Deprecate and remove ctypes usage in uuid

Steve Dower added the comment: There are three scenarios where ctypes is used in this module: * get libuuid.uuid_generate_time_safe and uuid_generate_time (if _uuid was not compiled) * get rpcrt4.UuidCreateSequential (on Windows, depending on how the libuuid lookup failed) *

[issue40501] Deprecate and remove ctypes usage in uuid

New submission from Steve Dower : The uuid module uses ctypes to try and load likely system libraries to provide some functionality of the uuid module. This is a security risk (depending on your sensitivity to DLL hijacking), but it also seems to be not very necessary? It would be nice to