[issue40584] PyType_FromModuleAndSpec function should add the process of tp_vectorcall_offset

2020-05-11 Thread STINNER Victor
Change by STINNER Victor : -- stage: resolved -> patch review ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue40584] PyType_FromModuleAndSpec function should add the process of tp_vectorcall_offset

2020-05-11 Thread STINNER Victor
STINNER Victor added the comment: Thanks Hai Shi! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue40584] PyType_FromModuleAndSpec function should add the process of tp_vectorcall_offset

2020-05-11 Thread STINNER Victor
STINNER Victor added the comment: New changeset 86d69444e7cfe758212956df0be0ec7b8a4251a6 by Hai Shi in branch 'master': bpo-40584: Update PyType_FromModuleAndSpec() to process tp_vectorcall_offset (GH-20026) https://github.com/python/cpython/commit/86d69444e7cfe758212956df0be0ec7b8a4251a6

[issue40584] PyType_FromModuleAndSpec function should add the process of tp_vectorcall_offset

2020-05-11 Thread hai shi
hai shi added the comment: > Note that __dictoffset__ and __weaklistoffset__ are also exposed as members > (in PyMemberDef type_members) and documented (Doc/c-api/structures.rst). A > new __vectorcalloffset__ should have that as well. Thanks for your comment, petr. And I updated the doc in

[issue40584] PyType_FromModuleAndSpec function should add the process of tp_vectorcall_offset

2020-05-11 Thread Petr Viktorin
Petr Viktorin added the comment: That seems reasonable. See the discussion around https://bugs.python.org/issue38140 for context. Note that __dictoffset__ and __weaklistoffset__ are also exposed as members (in PyMemberDef type_members) and documented (Doc/c-api/structures.rst). A new

[issue40584] PyType_FromModuleAndSpec function should add the process of tp_vectorcall_offset

2020-05-10 Thread hai shi
Change by hai shi : -- keywords: +patch pull_requests: +19336 stage: -> patch review pull_request: https://github.com/python/cpython/pull/20026 ___ Python tracker ___

[issue40584] PyType_FromModuleAndSpec function should add the process of tp_vectorcall_offset

2020-05-10 Thread hai shi
New submission from hai shi : some typeobject using `tp_vectorcall_offset`, if we use `PyType_FromModuleAndSpec` to create the the typeobject, it will be faild due to `PyType_FromModuleAndSpec` lack the process of `tp_vectorcall_offset`. so we should adding some process like