[issue40645] Use OpenSSL's HMAC API

Change by Christian Heimes : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue40645] Use OpenSSL's HMAC API

miss-islington added the comment: New changeset 1ee58f252454072a1c9da77999db8e6417a307a0 by Miss Islington (bot) in branch '3.10': bpo-40645: Fix ref leaks in _hashopenssl (GH-26079) https://github.com/python/cpython/commit/1ee58f252454072a1c9da77999db8e6417a307a0 --

[issue40645] Use OpenSSL's HMAC API

Change by miss-islington : -- pull_requests: +24721 pull_request: https://github.com/python/cpython/pull/26082 ___ Python tracker ___

[issue40645] Use OpenSSL's HMAC API

Change by Erlend E. Aasland : -- nosy: +erlendaasland nosy_count: 6.0 -> 7.0 pull_requests: +24718 pull_request: https://github.com/python/cpython/pull/26079 ___ Python tracker

[issue40645] Use OpenSSL's HMAC API

Change by Petr Viktorin : -- nosy: +petr.viktorin nosy_count: 5.0 -> 6.0 pull_requests: +24712 pull_request: https://github.com/python/cpython/pull/26072 ___ Python tracker

[issue40645] Use OpenSSL's HMAC API

miss-islington added the comment: New changeset 70cdf1812cf479c6b1cd7435a6fc0679ec1fb0da by Pablo Galindo in branch 'master': bpo-40645: Fix reference leak in the _hashopenssl extension (GH-25063) https://github.com/python/cpython/commit/70cdf1812cf479c6b1cd7435a6fc0679ec1fb0da --

[issue40645] Use OpenSSL's HMAC API

Change by Pablo Galindo Salgado : -- pull_requests: +23813 pull_request: https://github.com/python/cpython/pull/25063 ___ Python tracker ___

[issue40645] Use OpenSSL's HMAC API

Pablo Galindo Salgado added the comment: See for instance: https://buildbot.python.org/all/#/builders/75/builds/224 -- ___ Python tracker ___

[issue40645] Use OpenSSL's HMAC API

Pablo Galindo Salgado added the comment: Seems that commit 933dfd7504e521a27fd8b94d02b79f9ed08f4631 introduced some reference leaks: commit 933dfd7504e521a27fd8b94d02b79f9ed08f4631 Author: Christian Heimes Date: Sat Mar 27 14:55:03 2021 +0100 bpo-40645: use C implementation of HMAC

[issue40645] Use OpenSSL's HMAC API

miss-islington added the comment: New changeset 933dfd7504e521a27fd8b94d02b79f9ed08f4631 by Christian Heimes in branch 'master': bpo-40645: use C implementation of HMAC (GH-24920) https://github.com/python/cpython/commit/933dfd7504e521a27fd8b94d02b79f9ed08f4631 --

[issue40645] Use OpenSSL's HMAC API

Change by Christian Heimes : -- pull_requests: +23684 pull_request: https://github.com/python/cpython/pull/24920 ___ Python tracker ___

[issue40645] Use OpenSSL's HMAC API

Christian Heimes added the comment: memo to me: switch to new C implementation of HMAC. -- priority: normal -> critical versions: +Python 3.10 ___ Python tracker ___

[issue40645] Use OpenSSL's HMAC API

miss-islington added the comment: New changeset 6ed37430d31e915103ab5decd14d757eb2d159d5 by Miss Islington (bot) in branch '3.9': bpo-40645: restrict HMAC key len to INT_MAX (GH-20238) https://github.com/python/cpython/commit/6ed37430d31e915103ab5decd14d757eb2d159d5 --

[issue40645] Use OpenSSL's HMAC API

Change by miss-islington : -- pull_requests: +19533 pull_request: https://github.com/python/cpython/pull/20245 ___ Python tracker ___

[issue40645] Use OpenSSL's HMAC API

miss-islington added the comment: New changeset aca4670ad695d4b01c7880fe3d0af817421945bd by Christian Heimes in branch 'master': bpo-40645: restrict HMAC key len to INT_MAX (GH-20238) https://github.com/python/cpython/commit/aca4670ad695d4b01c7880fe3d0af817421945bd -- nosy:

[issue40645] Use OpenSSL's HMAC API

Christian Heimes added the comment: Thanks, Victor! -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue40645] Use OpenSSL's HMAC API

Change by Christian Heimes : -- pull_requests: +19526 pull_request: https://github.com/python/cpython/pull/20238 ___ Python tracker ___

[issue40645] Use OpenSSL's HMAC API

STINNER Victor added the comment: Compiler warning on 64-bit Windows: c:\vstinner\python\3.9\modules\_hashopenssl.c(1427): warning C4244: 'function': conversion from 'Py_ssize_t' to 'int', possible loss of data -- nosy: +vstinner ___ Python

[issue40645] Use OpenSSL's HMAC API

Christian Heimes added the comment: New changeset 54f2898fe7e4ca1f239e96284af3cc5b34d2ae02 by Christian Heimes in branch 'master': bpo-40645: Implement HMAC in C (GH-20129) https://github.com/python/cpython/commit/54f2898fe7e4ca1f239e96284af3cc5b34d2ae02 --

[issue40645] Use OpenSSL's HMAC API

Christian Heimes added the comment: def new(key, msg=None, digestmod=''): # use fast HMAC if OpenSSL bindings are available and digestmod is # either a string or a callable that returns an OpenSSL HASH object. if _hashopenssl is not None: if isinstance(digestmod, str):

[issue40645] Use OpenSSL's HMAC API

Christian Heimes added the comment: New changeset 837f9e42e3a1ad03b340661afe85e67d2719334f by Christian Heimes in branch 'master': bpo-40645: Deprecated internal details of hmac.HMAC (GH-20132) https://github.com/python/cpython/commit/837f9e42e3a1ad03b340661afe85e67d2719334f --

[issue40645] Use OpenSSL's HMAC API

Change by Christian Heimes : -- pull_requests: +19437 pull_request: https://github.com/python/cpython/pull/20132 ___ Python tracker ___

[issue40645] Use OpenSSL's HMAC API

Change by Christian Heimes : -- keywords: +patch pull_requests: +19434 pull_request: https://github.com/python/cpython/pull/20129 ___ Python tracker ___

[issue40645] Use OpenSSL's HMAC API

New submission from Christian Heimes : Python's hmac module provides a pure Python based implementation on top of the hashlib module. OpenSSL offers a dedicated HMAC implementation that has a couple of benefits over pure Python implementation: - OpenSSL HMAC is slightly faster and requires