[issue40653] _dirnameW is used outside HAVE_SYMLINK

miss-islington added the comment: New changeset ddd5bbdeec8cf18ef074b3506c96d22ac3dc1f93 by Miss Islington (bot) in branch '3.8': bpo-40653: Move _dirnameW out of GH-ifdef HAVE_SYMLINK/GH-endif (GH-20144) https://github.com/python/cpython/commit/ddd5bbdeec8cf18ef074b3506c96d22ac3dc1f93

[issue40653] _dirnameW is used outside HAVE_SYMLINK

miss-islington added the comment: New changeset 6da26f8cec5c3f012e2fd001042ccadcd8aba640 by Miss Islington (bot) in branch '3.7': bpo-40653: Move _dirnameW out of GH-ifdef HAVE_SYMLINK/GH-endif (GH-20144) https://github.com/python/cpython/commit/6da26f8cec5c3f012e2fd001042ccadcd8aba640

[issue40653] _dirnameW is used outside HAVE_SYMLINK

Steve Dower added the comment: Thanks! Nice catch. Closing this, but I'll keep an eye on the backports. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue40653] _dirnameW is used outside HAVE_SYMLINK

Change by miss-islington : -- pull_requests: +19487 pull_request: https://github.com/python/cpython/pull/20186 ___ Python tracker ___

[issue40653] _dirnameW is used outside HAVE_SYMLINK

Change by miss-islington : -- nosy: +miss-islington nosy_count: 5.0 -> 6.0 pull_requests: +19486 pull_request: https://github.com/python/cpython/pull/20185 ___ Python tracker

[issue40653] _dirnameW is used outside HAVE_SYMLINK

Steve Dower added the comment: New changeset 7f21c9ac872acc2114aee3313d132b016550ff42 by Minmin Gong in branch 'master': bpo-40653: Move _dirnameW out of #ifdef HAVE_SYMLINK/#endif (GH-20144) https://github.com/python/cpython/commit/7f21c9ac872acc2114aee3313d132b016550ff42 --

[issue40653] _dirnameW is used outside HAVE_SYMLINK

Change by Minmin Gong : -- keywords: +patch pull_requests: +19449 stage: -> patch review pull_request: https://github.com/python/cpython/pull/20144 ___ Python tracker ___

[issue40653] _dirnameW is used outside HAVE_SYMLINK

New submission from Minmin Gong : _dirnameW is defined inside #ifdef HAVE_SYMLINK/#endif, but it's used in os__getdiskusage_impl, which is outside HAVE_SYMLINK. So if HAVE_SYMLINK is not defined (e.g., on UWP), it'll have compiling issues. -- components: Windows messages: 369089