[issue40686] Compiler warnings in _zoneinfo.c on Windows build in 64-bit

STINNER Victor added the comment: Paul created a follow-up issue: bpo-42660. -- ___ Python tracker ___ ___ Python-bugs-list

[issue40686] Compiler warnings in _zoneinfo.c on Windows build in 64-bit

STINNER Victor added the comment: New changeset 7492b55ea0ca993c353b6373341b92e40faa9c4d by Miss Islington (bot) in branch '3.9': bpo-40686: Fix compiler warnings on _zoneinfo.c (GH-23614) (GH-23804) https://github.com/python/cpython/commit/7492b55ea0ca993c353b6373341b92e40faa9c4d

[issue40686] Compiler warnings in _zoneinfo.c on Windows build in 64-bit

STINNER Victor added the comment: Fixing these compiler warnings helps PR 18532 "[workflow] Use MSVC problem matcher for Windows action build". -- ___ Python tracker ___

[issue40686] Compiler warnings in _zoneinfo.c on Windows build in 64-bit

STINNER Victor added the comment: The 3 compiler warnings are now fixed in master, and a 3.9 backport will land as soon as the CI tests pass. Thanks everyone who helped to fix these warnings. I know that the solution is not perfect, but we have to deal with C language limitations.

[issue40686] Compiler warnings in _zoneinfo.c on Windows build in 64-bit

Change by miss-islington : -- nosy: +miss-islington nosy_count: 5.0 -> 6.0 pull_requests: +22664 pull_request: https://github.com/python/cpython/pull/23804 ___ Python tracker

[issue40686] Compiler warnings in _zoneinfo.c on Windows build in 64-bit

STINNER Victor added the comment: New changeset aefb69b23f056c61e82ad228d950f348de090c70 by Victor Stinner in branch 'master': bpo-40686: Fix compiler warnings on _zoneinfo.c (GH-23614) https://github.com/python/cpython/commit/aefb69b23f056c61e82ad228d950f348de090c70 --

[issue40686] Compiler warnings in _zoneinfo.c on Windows build in 64-bit

STINNER Victor added the comment: The problem can be simplified to this x.c file: --- static int invalid_day(unsigned int day) { return (day < 0 || day > 6); } int main() { invalid_day(3); return 0; } --- GCC emits the warning: $ gcc x.c -o x -O3 -Wall -Wextra x.c: In function

[issue40686] Compiler warnings in _zoneinfo.c on Windows build in 64-bit

Change by STINNER Victor : -- pull_requests: +22482 pull_request: https://github.com/python/cpython/pull/23614 ___ Python tracker ___

[issue40686] Compiler warnings in _zoneinfo.c on Windows build in 64-bit

Change by Paul Ganssle : -- pull_requests: +19849 pull_request: https://github.com/python/cpython/pull/20624 ___ Python tracker ___

[issue40686] Compiler warnings in _zoneinfo.c on Windows build in 64-bit

Change by Dong-hee Na : -- keywords: +patch pull_requests: +19845 stage: -> patch review pull_request: https://github.com/python/cpython/pull/20619 ___ Python tracker ___

[issue40686] Compiler warnings in _zoneinfo.c on Windows build in 64-bit

Ammar Askar added the comment: There's still the "unknown pragma" warnings left, I pinged p-ganssle about it in the zoneinfo commit but it should probably be guarded like the ones in the ssl module:

[issue40686] Compiler warnings in _zoneinfo.c on Windows build in 64-bit

Pablo Galindo Salgado added the comment: > 1. GH-20342 solved this issue? As far as I understand, yes. Although I did not check if all the warnings here are solved in that PR, as the PR eliminates all the ones that we found, it should be resolved. I think we can close this issue > Thanks

[issue40686] Compiler warnings in _zoneinfo.c on Windows build in 64-bit

Dong-hee Na added the comment: Two things. 1. GH-20342 solved this issue? 2. If not what's left for this issue? :) Sorry, Normally I should check the current status. But I don't have Windows machine so I can not test it. However the update will help contributors who want to deal with :)

[issue40686] Compiler warnings in _zoneinfo.c on Windows build in 64-bit

Pablo Galindo Salgado added the comment: > Can you update the current status? Sorry, what do you mean by "current status"? Do you meant this issue or the status of that PR? -- ___ Python tracker

[issue40686] Compiler warnings in _zoneinfo.c on Windows build in 64-bit

Dong-hee Na added the comment: @pablogsal GH-20342 looks like related to this issue. Can you update the current status? -- nosy: +corona10, pablogsal ___ Python tracker ___

[issue40686] Compiler warnings in _zoneinfo.c on Windows build in 64-bit

New submission from STINNER Victor : c:\vstinner\python\3.9\modules\_zoneinfo.c(903): warning C4267: '=': conversion from 'size_t' to 'unsigned int', possible loss of data [C:\vstinner\python\3.9\PCbuild\_ zoneinfo.vcxproj] c:\vstinner\python\3.9\modules\_zoneinfo.c(904): warning C4267: '=':