[issue40726] ast.Call end_lineno is defined and returns None

Change by Pablo Galindo Salgado : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue40726] ast.Call end_lineno is defined and returns None

miss-islington added the comment: New changeset b24c9d2b0656764bef48120d9511faf833bd7ead by Batuhan Taskaya in branch '3.8': [3.8] bpo-40726: handle uninitalized end_lineno on ast.increment_lineno (GH-21745) https://github.com/python/cpython/commit/b24c9d2b0656764bef48120d9511faf833bd7ead

[issue40726] ast.Call end_lineno is defined and returns None

Change by Batuhan Taskaya : -- pull_requests: +20889 pull_request: https://github.com/python/cpython/pull/21745 ___ Python tracker ___

[issue40726] ast.Call end_lineno is defined and returns None

miss-islington added the comment: New changeset a1320989f5350439e0677450f49b36f2c10583d2 by Miss Islington (bot) in branch '3.9': bpo-40726: handle uninitalized end_lineno on ast.increment_lineno (GH-20312) https://github.com/python/cpython/commit/a1320989f5350439e0677450f49b36f2c10583d2

[issue40726] ast.Call end_lineno is defined and returns None

Change by Pablo Galindo Salgado : -- pull_requests: +20888 pull_request: https://github.com/python/cpython/pull/21742 ___ Python tracker ___

[issue40726] ast.Call end_lineno is defined and returns None

Change by miss-islington : -- nosy: +miss-islington nosy_count: 7.0 -> 8.0 pull_requests: +20887 pull_request: https://github.com/python/cpython/pull/21741 ___ Python tracker

[issue40726] ast.Call end_lineno is defined and returns None

Pablo Galindo Salgado added the comment: New changeset 8f4380d2f5839a321475104765221a7394a9d649 by Batuhan Taskaya in branch 'master': bpo-40726: handle uninitalized end_lineno on ast.increment_lineno (GH-20312)

[issue40726] ast.Call end_lineno is defined and returns None

Change by Florian Dahlitz : -- nosy: -DahlitzFlorian ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue40726] ast.Call end_lineno is defined and returns None

David Strobach added the comment: > Actually, Xonsh tests show that keyword AST nodes are missing 'lineno' > attribute, but that could be our fault. Yes, our fault. Sorry for the noise. -- ___ Python tracker

[issue40726] ast.Call end_lineno is defined and returns None

David Strobach added the comment: Actually, Xonsh (http://github.com/xonsh/xonsh) tests show that keyword AST nodes are missing 'lineno' attribute, but that could be our fault. -- ___ Python tracker

[issue40726] ast.Call end_lineno is defined and returns None

Batuhan Taskaya added the comment: > setting them to None is going to break a lot of those, if possible I'd > suggest going back to when they were missing 'lineno' and 'col_offset' will never be none, since both are declared as normal integers. But on the other hand, 'end_lineno' and

[issue40726] ast.Call end_lineno is defined and returns None

Change by Pablo Galindo Salgado : -- nosy: +serhiy.storchaka ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue40726] ast.Call end_lineno is defined and returns None

Anthony Sottile added the comment: There's current expectation in a lot of linters / code formatters that the *lineno and *col_offset attributes will be missing if they are not attached to the node setting them to None is going to break a lot of those, if possible I'd suggest going back to

[issue40726] ast.Call end_lineno is defined and returns None

Batuhan Taskaya added the comment: > If nobody works on this I will send a PR to update the rest of AST later > today. :/ I'm terribly sorry for that, I just sent a PR without refreshing the tab. -- ___ Python tracker

[issue40726] ast.Call end_lineno is defined and returns None

Change by Batuhan Taskaya : -- keywords: +patch nosy: +BTaskaya nosy_count: 5.0 -> 6.0 pull_requests: +19581 stage: -> patch review pull_request: https://github.com/python/cpython/pull/20312 ___ Python tracker

[issue40726] ast.Call end_lineno is defined and returns None

Change by Florian Dahlitz : -- nosy: +DahlitzFlorian ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue40726] ast.Call end_lineno is defined and returns None

Rémi Lapeyre added the comment: This was done in b7e9525f9c7ef02a1d2ad8253afdeb733b0951d4 for issue 36287, all attribute should now be defined, even when they are not set. It looks like some parts of the ast module where not updated. If nobody works on this I will send a PR to update the

[issue40726] ast.Call end_lineno is defined and returns None

Change by Batuhan Taskaya : -- nosy: +serhiy.storchaka ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue40726] ast.Call end_lineno is defined and returns None

Batuhan Taskaya added the comment: See here for the complete spec: https://docs.python.org/3.9/library/ast.html#abstract-grammar -- ___ Python tracker ___

[issue40726] ast.Call end_lineno is defined and returns None

Batuhan Taskaya added the comment: This is because the 'end_lineno' and 'end_col_offset' are declared as optional attributes in the ASDL spec. The commit 'b7e9525f9c7ef02a1d2ad8253afdeb733b0951d4' made all optional fields and attributes auto initalized with None. --

[issue40726] ast.Call end_lineno is defined and returns None

Change by Batuhan Taskaya : -- nosy: +BTaskaya ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue40726] ast.Call end_lineno is defined and returns None

David Strobach added the comment: The issue is not limited to ast.Call. Other AST nodes are also affected (e.g. ast.BinOp). It's also not limited to end_lineno attribute. The same applies to end_col_offset. -- ___ Python tracker

[issue40726] ast.Call end_lineno is defined and returns None

Change by David Strobach : -- nosy: +laloch ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue40726] ast.Call end_lineno is defined and returns None

Change by Karthikeyan Singaravelan : -- nosy: +pablogsal ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue40726] ast.Call end_lineno is defined and returns None

New submission from gaborbernat : Reporting an issue from https://github.com/xonsh/xonsh/issues/3581; boils down to, ast.Call used to not define end_lineno in 3.8: py -3.8 -c 'import ast; type(ast.Call().end_lineno)'