[issue4073] distutils build_scripts and install_data commands need 2to3 support

Martin v. Löwis <[EMAIL PROTECTED]> added the comment: Committed as r67464. -- resolution: -> fixed status: open -> closed ___ Python tracker <[EMAIL PROTECTED]> ___ _

[issue4073] distutils build_scripts and install_data commands need 2to3 support

Benjamin Peterson <[EMAIL PROTECTED]> added the comment: Ok. Looks good. -- keywords: -needs review ___ Python tracker <[EMAIL PROTECTED]> ___

[issue4073] distutils build_scripts and install_data commands need 2to3 support

Changes by Martin v. Löwis <[EMAIL PROTECTED]>: Removed file: http://bugs.python.org/file11803/build_scripts.diff ___ Python tracker <[EMAIL PROTECTED]> ___ ___

[issue4073] distutils build_scripts and install_data commands need 2to3 support

Martin v. Löwis <[EMAIL PROTECTED]> added the comment: Thanks for the review. Here is a revised version, addressing comments 1 and 2. Comment 3 is address by exposing all arguments to RefactoringTool as class variables in a new class Mixin2to3, from which build_py and build_scripts inherit. Add

[issue4073] distutils build_scripts and install_data commands need 2to3 support

Changes by Lars Immisch <[EMAIL PROTECTED]>: -- nosy: +larsimmisch ___ Python tracker <[EMAIL PROTECTED]> ___ ___ Python-bugs-list maili

[issue4073] distutils build_scripts and install_data commands need 2to3 support

Benjamin Peterson <[EMAIL PROTECTED]> added the comment: Review: 1. Since RefactoringTool no longer writes backup files, write_file doesn't need to be overridden. 2. Don't worry about **kwds on log_error. It's not used at the moment. 3. It might be nice to let users pick which fixers they do o

[issue4073] distutils build_scripts and install_data commands need 2to3 support

Martin v. Löwis <[EMAIL PROTECTED]> added the comment: I'd like to see this in 3.0. It will help people porting to 3.0 better. -- assignee: -> barry nosy: +barry priority: -> release blocker ___ Python tracker <[EMAIL PROTECTED]>

[issue4073] distutils build_scripts and install_data commands need 2to3 support

Martin v. Löwis <[EMAIL PROTECTED]> added the comment: > All .py files should be converted. I disagree. For example, people decided that all .py files in Tools should get converted, converting Tools/msi in the process. Now, Tools/msi is intended to be run in an *older* Python version than the on

[issue4073] distutils build_scripts and install_data commands need 2to3 support

Mark Hammond <[EMAIL PROTECTED]> added the comment: Thinking more about data_files, I'd agree that blindly converting all .py files and nothing more isn't as useful for install_data as the other commands. It might make more sense to allow data_files to specify a list of patterns that will be mat

[issue4073] distutils build_scripts and install_data commands need 2to3 support

Mark Hammond <[EMAIL PROTECTED]> added the comment: > I'm skeptical about adding build_data support, as it's not > obvious what files would need conversion. All .py files should be converted. I can't think why a project would use this 2to3 capability for scripts and packages, but not .py files

[issue4073] distutils build_scripts and install_data commands need 2to3 support

Benjamin Peterson <[EMAIL PROTECTED]> added the comment: Ok. I've refactored RefactoringTool so that the write_file method doesn't make a backup file by default. ___ Python tracker <[EMAIL PROTECTED]>

[issue4073] distutils build_scripts and install_data commands need 2to3 support

Martin v. Löwis <[EMAIL PROTECTED]> added the comment: > If you'd like, I can add support for skipping backup files to 2to3. That would be useful, I think. ___ Python tracker <[EMAIL PROTECTED]> _

[issue4073] distutils build_scripts and install_data commands need 2to3 support

Benjamin Peterson <[EMAIL PROTECTED]> added the comment: If you'd like, I can add support for skipping backup files to 2to3. -- nosy: +benjamin.peterson ___ Python tracker <[EMAIL PROTECTED]>

[issue4073] distutils build_scripts and install_data commands need 2to3 support

Changes by Martin v. Löwis <[EMAIL PROTECTED]>: Added file: http://bugs.python.org/file11803/build_scripts.diff ___ Python tracker <[EMAIL PROTECTED]> ___ _

[issue4073] distutils build_scripts and install_data commands need 2to3 support

Changes by Martin v. Löwis <[EMAIL PROTECTED]>: Removed file: http://bugs.python.org/file11802/build_scripts.diff ___ Python tracker <[EMAIL PROTECTED]> ___ ___

[issue4073] distutils build_scripts and install_data commands need 2to3 support

Changes by Martin v. Löwis <[EMAIL PROTECTED]>: Added file: http://bugs.python.org/file11802/build_scripts.diff ___ Python tracker <[EMAIL PROTECTED]> ___ _

[issue4073] distutils build_scripts and install_data commands need 2to3 support

Changes by Martin v. Löwis <[EMAIL PROTECTED]>: Removed file: http://bugs.python.org/file11801/build_scripts.diff ___ Python tracker <[EMAIL PROTECTED]> ___ ___

[issue4073] distutils build_scripts and install_data commands need 2to3 support

Martin v. Löwis <[EMAIL PROTECTED]> added the comment: Here is a patch. It refactors the 2to3 support into a function in util, and adds build_scripts support. For build_scripts, the approach is slightly different from the one proposed by Mark: I modify copy_scripts to collect the modified files,

[issue4073] distutils build_scripts and install_data commands need 2to3 support

Changes by Thomas Heller <[EMAIL PROTECTED]>: -- nosy: +theller ___ Python tracker <[EMAIL PROTECTED]> ___ ___ Python-bugs-list mailing

[issue4073] distutils build_scripts and install_data commands need 2to3 support

New submission from Mark Hammond <[EMAIL PROTECTED]>: The distutils commands 'build_scripts' and 'install_data' both may end up installing .py files. Such .py file should be able tobe run through lib2to3 in the same way supported by build_py. pywin32 has ended up with something like: class