[issue40956] Use Argument Clinic in sqlite3

Erlend E. Aasland added the comment: > Erlend, is anything left in this issue? Nothing left; thank you for your guidance and reviews, Dong-hee, Berker, Serhiy, and Pablo. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed

[issue40956] Use Argument Clinic in sqlite3

Pablo Galindo Salgado added the comment: Erlend, is anything left in this issue? -- ___ Python tracker ___ ___ Python-bugs-list

[issue40956] Use Argument Clinic in sqlite3

Pablo Galindo Salgado added the comment: New changeset 185ecdc1463c527743eeb16a5deef75c1985de79 by Erlend Egeberg Aasland in branch 'main': bpo-40956: Convert sqlite3.connect and sqlite3.Connection.__init__ to AC (GH-24421)

[issue40956] Use Argument Clinic in sqlite3

Berker Peksag added the comment: New changeset ea46579067fd2d4e164d6605719ffec690c4d621 by Erlend Egeberg Aasland in branch 'master': bpo-40956: Fix segfault when Connection.backup is called without target (GH-24503)

[issue40956] Use Argument Clinic in sqlite3

Change by Erlend Egeberg Aasland : -- pull_requests: +23293 pull_request: https://github.com/python/cpython/pull/24503 ___ Python tracker ___

[issue40956] Use Argument Clinic in sqlite3

Change by Erlend Egeberg Aasland : -- pull_requests: +23236 pull_request: https://github.com/python/cpython/pull/24421 ___ Python tracker ___

[issue40956] Use Argument Clinic in sqlite3

Berker Peksag added the comment: New changeset a330365ca5ae836075f306334ab648bf23471481 by Erlend Egeberg Aasland in branch 'master': bpo-40956: Fix sqlite3.Cursor.fetchmany() default value (GH-24214) https://github.com/python/cpython/commit/a330365ca5ae836075f306334ab648bf23471481

[issue40956] Use Argument Clinic in sqlite3

Change by Erlend Egeberg Aasland : -- pull_requests: +23041 pull_request: https://github.com/python/cpython/pull/24214 ___ Python tracker ___

[issue40956] Use Argument Clinic in sqlite3

Erlend Egeberg Aasland added the comment: Thanks, but I prefer the following: size as maxrows: int(c_default='self->arraysize', py_default='') = 1 -- ___ Python tracker ___

[issue40956] Use Argument Clinic in sqlite3

Serhiy Storchaka added the comment: Use NULL. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue40956] Use Argument Clinic in sqlite3

Erlend Egeberg Aasland added the comment: I don't see how to easily solve this in AC: we want the arraysize of the cursor instance, but I don't see how I'm going to get this via the AC namespace/context. Using a "bogus" default value works: size as maxrows: int(c_default='self->arraysize')

[issue40956] Use Argument Clinic in sqlite3

Erlend Egeberg Aasland added the comment: Looks like this is the culprit: https://github.com/python/cpython/blob/2396614b8958ad202378fd71a598eb4106ac5896/Modules/_sqlite/cursor.c#L825 -- ___ Python tracker

[issue40956] Use Argument Clinic in sqlite3

Erlend Egeberg Aasland added the comment: GH-24007 introduced a regression: >>> import sqlite3 >>> help(sqlite3) Traceback (most recent call last): File "Lib/inspect.py", line 2049, in wrap_value value = eval(s, module_dict) File "", line 1, in NameError: name 'cursor' is not defined

[issue40956] Use Argument Clinic in sqlite3

Change by Erlend Egeberg Aasland : -- pull_requests: +22965 pull_request: https://github.com/python/cpython/pull/24135 ___ Python tracker ___

[issue40956] Use Argument Clinic in sqlite3

Berker Peksag added the comment: New changeset c7f8d3caf0b10c19cd46b1b334a98628eac15672 by Erlend Egeberg Aasland in branch 'master': bpo-40956: Convert _sqlite3.Cursor to Argument Clinic (GH-24007) https://github.com/python/cpython/commit/c7f8d3caf0b10c19cd46b1b334a98628eac15672

[issue40956] Use Argument Clinic in sqlite3

Change by Erlend Egeberg Aasland : -- pull_requests: +22849 pull_request: https://github.com/python/cpython/pull/24007 ___ Python tracker ___

[issue40956] Use Argument Clinic in sqlite3

Serhiy Storchaka added the comment: New changeset 84d79cfda947f6bc28a5aa11db8055aa40a6b03a by Erlend Egeberg Aasland in branch 'master': bpo-40956: Convert _sqlite3.Row to Argument Clinic (GH-23964) https://github.com/python/cpython/commit/84d79cfda947f6bc28a5aa11db8055aa40a6b03a

[issue40956] Use Argument Clinic in sqlite3

Change by Erlend Egeberg Aasland : -- pull_requests: +22809 pull_request: https://github.com/python/cpython/pull/23964 ___ Python tracker ___

[issue40956] Use Argument Clinic in sqlite3

Dong-hee Na added the comment: New changeset 3ccef1ca474592e191a00e131dfbaf777db271e9 by Erlend Egeberg Aasland in branch 'master': bpo-40956: Convert _sqlite3.Connection to Argument Clinic, part 2 (GH-23838) https://github.com/python/cpython/commit/3ccef1ca474592e191a00e131dfbaf777db271e9

[issue40956] Use Argument Clinic in sqlite3

Change by Erlend Egeberg Aasland : -- pull_requests: +22697 pull_request: https://github.com/python/cpython/pull/23838 ___ Python tracker ___

[issue40956] Use Argument Clinic in sqlite3

Dong-hee Na added the comment: New changeset 2179349d8cf45b1202775547df384b1fde31630a by Dong-hee Na in branch 'master': bpo-40956: Fix sqlite3 AC code (GH-23837) https://github.com/python/cpython/commit/2179349d8cf45b1202775547df384b1fde31630a --

[issue40956] Use Argument Clinic in sqlite3

Change by Dong-hee Na : -- pull_requests: +22696 pull_request: https://github.com/python/cpython/pull/23837 ___ Python tracker ___

[issue40956] Use Argument Clinic in sqlite3

Dong-hee Na added the comment: New changeset 1ba82bbc50a52f40ad05f3c4aaf2e159e0ce126d by Erlend Egeberg Aasland in branch 'master': bpo-40956: Convert _sqlite3.Connection to Argument Clinic (GH-23341) https://github.com/python/cpython/commit/1ba82bbc50a52f40ad05f3c4aaf2e159e0ce126d

[issue40956] Use Argument Clinic in sqlite3

Change by Erlend Egeberg Aasland : -- pull_requests: +22232 pull_request: https://github.com/python/cpython/pull/23341 ___ Python tracker ___

[issue40956] Use Argument Clinic in sqlite3

Erlend Egeberg Aasland added the comment: > Thank you erlendaasland for working on GH-22484. … and thank you for taking the time to review this! -- ___ Python tracker ___

[issue40956] Use Argument Clinic in sqlite3

Change by Erlend Egeberg Aasland : -- pull_requests: +21976 pull_request: https://github.com/python/cpython/pull/23057 ___ Python tracker ___

[issue40956] Use Argument Clinic in sqlite3

Dong-hee Na added the comment: @erlendaasland Thank you erlendaasland for working on GH-22484. This time was a good time to review my AC knowledge ;) -- ___ Python tracker

[issue40956] Use Argument Clinic in sqlite3

Dong-hee Na added the comment: New changeset 7d210271579ae31f43b32f73c2aff5bc4fe0d27f by Erlend Egeberg Aasland in branch 'master': bpo-40956: Convert _sqlite3 module level functions to Argument Clinic (GH-22484)

[issue40956] Use Argument Clinic in sqlite3

Erlend Egeberg Aasland added the comment: By the way, what's the preferred way to benchmark performance? -- ___ Python tracker ___

[issue40956] Use Argument Clinic in sqlite3

Dong-hee Na added the comment: > Also, see the comment from Victor here: > https://github.com/python/cpython/pull/22478#issuecomment-702201260 Okay got it -- ___ Python tracker

[issue40956] Use Argument Clinic in sqlite3

Erlend Egeberg Aasland added the comment: Also, see the comment from Victor here: https://github.com/python/cpython/pull/22478#issuecomment-702201260 -- ___ Python tracker

[issue40956] Use Argument Clinic in sqlite3

Erlend Egeberg Aasland added the comment: The primary reason is that it will be provide easy access to module state. The first step in making sqlite3 support multiphase init was to create heap types. The second step is argument clinic. The third will be to use AC for module state. The last

[issue40956] Use Argument Clinic in sqlite3

Dong-hee Na added the comment: What's the purpose of using AC, did the change improve performance? It can make hard to track the code history. -- nosy: +corona10 ___ Python tracker

[issue40956] Use Argument Clinic in sqlite3

Change by Erlend Egeberg Aasland : -- nosy: +berker.peksag, vstinner ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue40956] Use Argument Clinic in sqlite3

Change by Erlend Egeberg Aasland : -- pull_requests: +21654 pull_request: https://github.com/python/cpython/pull/22478 ___ Python tracker ___

[issue40956] Use Argument Clinic in sqlite3

Change by Erlend Egeberg Aasland : -- pull_requests: +21501 pull_request: https://github.com/python/cpython/pull/22484 ___ Python tracker ___

[issue40956] Use Argument Clinic in sqlite3

Change by Erlend Egeberg Aasland : -- keywords: +patch pull_requests: +20021 stage: -> patch review pull_request: https://github.com/python/cpython/pull/20826 ___ Python tracker

[issue40956] Use Argument Clinic in sqlite3

New submission from Erlend Egeberg Aasland : Use Argument Clinic in sqlite3. -- components: Library (Lib) messages: 371347 nosy: erlendaasland priority: normal severity: normal status: open title: Use Argument Clinic in sqlite3 type: enhancement versions: Python 3.10