[issue41002] HTTPResponse.read with amt is slow

Change by Inada Naoki : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___ P

[issue41002] HTTPResponse.read with amt is slow

miss-islington added the comment: New changeset 152f0b8beea12e6282d284100b600771b968927a by Bruce Merry in branch 'master': bpo-41002: Optimize HTTPResponse.read with a given amount (GH-20943) https://github.com/python/cpython/commit/152f0b8beea12e6282d284100b600771b968927a -- nosy:

[issue41002] HTTPResponse.read with amt is slow

Open Close added the comment: @bmerry yah, sorry, don't bother. I have mistaken. (I thought somehow 'MB/s' was simple speed, not std). I confirmed your tests. httpclient-read: 2504.5 ± 10.6 MB/s httpclient-read-length: 871.5 ± 4.9 MB/s httpclient-read-raw: 2528.3 ± 3.6 MB/s sock

[issue41002] HTTPResponse.read with amt is slow

Bruce Merry added the comment: > (perhaps 'MB/s's are wrong). Why, are you getting significantly different results? Just in case it's confusing, the results are reported as A ± B MB/s, where A is the mean and B is the standard deviation of the mean. So it's about 3GB/s when no length if pass

[issue41002] HTTPResponse.read with amt is slow

Open Close added the comment: @bmerry check the test results again. (perhaps 'MB/s's are wrong). httpclient-read: 3019.0 ± 63.8 MB/s httpclient-read-length: 1050.3 ± 4.8 MB/s --> httpclient-read-raw: 3150.3 ± 5.3 MB/s --> socket-read: 3134.4 ± 7.9 MB/s -- nosy: +op368

[issue41002] HTTPResponse.read with amt is slow

Change by Inada Naoki : -- nosy: +inada.naoki versions: +Python 3.10 -Python 3.8 ___ Python tracker ___ ___ Python-bugs-list mailing

[issue41002] HTTPResponse.read with amt is slow

Change by Bruce Merry : -- keywords: +patch pull_requests: +20124 stage: -> patch review pull_request: https://github.com/python/cpython/pull/20943 ___ Python tracker ___

[issue41002] HTTPResponse.read with amt is slow

Change by Bruce Merry : -- type: -> performance ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail

[issue41002] HTTPResponse.read with amt is slow

New submission from Bruce Merry : I've run into this on 3.8, but the code on Git master doesn't look significantly different so I assume it still applies. I'm happy to work on a PR for this. When http.client.HTTPResponse.read is called with a specific amount to read, it goes down this code pa