[issue41013] test_os.test_memfd_create() fails on AMD64 FreeBSD Shared 3.x

STINNER Victor added the comment: test_os pass again on FreeBSD Shared 3.x, I close the issue. -- resolution: -> fixed stage: -> resolved status: open -> closed ___ Python tracker _

[issue41013] test_os.test_memfd_create() fails on AMD64 FreeBSD Shared 3.x

Kubilay Kocak added the comment: @Kyle Yes, msg373597 freebsd CURRENT buildbot passes, but freebsd 12/stable does not (cannot, since stable/12 wont get the syscall) That means the Python memfd functions and tests need to account for this -- ___ Py

[issue41013] test_os.test_memfd_create() fails on AMD64 FreeBSD Shared 3.x

Kyle Evans added the comment: Hey koobs, Can you confirm that this is fine now after I implemented SHM_GROW_ON_WRITE? -- ___ Python tracker ___ __

[issue41013] test_os.test_memfd_create() fails on AMD64 FreeBSD Shared 3.x

Kyle Evans added the comment: I can confirm that neither 12 nor 11 will be getting memfd_create; file sealing is a little more complicated to MFC, and I don't want to provide memfd_create in a place where it can't be paired with file sealing in case applications assume they come hand-in-hand

[issue41013] test_os.test_memfd_create() fails on AMD64 FreeBSD Shared 3.x

Kubilay Kocak added the comment: I've updated the FreeBSD CURRENT buildbot past base/r363065 [1] which implements SHM_GROW_ON_WRITE: https://svnweb.freebsd.org/changeset/base/363065 https://reviews.freebsd.org/D25502 Also worth noting that I don't believe stable/12 (FreeBSD 12.x) will be get

[issue41013] test_os.test_memfd_create() fails on AMD64 FreeBSD Shared 3.x

Kyle Evans added the comment: Ah, sorry, I meant to update this- I submitted our fix for review a day or two ago, got approval for commit and will poke koobs to rebuild the FreeBSD -CURRENT buildbot with it after that. -- ___ Python tracker

[issue41013] test_os.test_memfd_create() fails on AMD64 FreeBSD Shared 3.x

Łukasz Langa added the comment: As a regression this would have been a release blocker, this also fails on 3.9 and 3.8. However, given that this has only been surfaced by Christian's fix to the testing machinery in GH-20942, I'll mark this as deferred blocker instead for visibility.

[issue41013] test_os.test_memfd_create() fails on AMD64 FreeBSD Shared 3.x

STINNER Victor added the comment: > So in my local repro, Python is looping forever on successful write() for > reasons I'm not immediately sure of. io.BufferedWriter.write() (well, especially its flush() method) calls write() until all data is written. Extract of _bufferedwriter_flush_unlo

[issue41013] test_os.test_memfd_create() fails on AMD64 FreeBSD Shared 3.x

Kyle Evans added the comment: Ah, now that I'm more awake, I see the problem- the write is unsuccessful because I haven't yet implemented grow-on-write. None of the consumers that I had found relied on it, instead choosing to ftruncate() it to the size they need before operating on it. I th

[issue41013] test_os.test_memfd_create() fails on AMD64 FreeBSD Shared 3.x

Kyle Evans added the comment: (Transcription error beyond the bogus os.exit() :-)) -- ___ Python tracker ___ ___ Python-bugs-list m

[issue41013] test_os.test_memfd_create() fails on AMD64 FreeBSD Shared 3.x

Kyle Evans added the comment: I think it's too early to look at this, I'll circle back another time. :-) I got a minute and extracted the relevant test, but I guess there must have been some fundamental transcription error: import os fd = os.memfd_create("Hi", os.MFD_CLOEXEC) if fd == -1:

[issue41013] test_os.test_memfd_create() fails on AMD64 FreeBSD Shared 3.x

Christian Heimes added the comment: The traceback points to line 3520, which calls f.tell() on a file object that wraps a memfd. -- ___ Python tracker ___ ___

[issue41013] test_os.test_memfd_create() fails on AMD64 FreeBSD Shared 3.x

Kyle Evans added the comment: Interesting; I don't quite have time to look at the moment, but what is the test doing that it's ultimately timing out? Our memfd_create is assumed to be compatible, with the exception that we don't yet support HUGETLB (but there are patches in progress for the

[issue41013] test_os.test_memfd_create() fails on AMD64 FreeBSD Shared 3.x

Kubilay Kocak added the comment: memfd_create came in via: https://github.com/freebsd/freebsd/commit/575e351fdd996f72921b87e71c2c26466e887ed2 via review: https://reviews.freebsd.org/D21393 via kevans (cc'd) -- nosy: +kevans ___ Python tracker <

[issue41013] test_os.test_memfd_create() fails on AMD64 FreeBSD Shared 3.x

Christian Heimes added the comment: Commit bb6ec14479f18c32e71e43f2785f177aa17aabbd fixed a problem with tests, so the test is now executed. Does FreeBSD have an implementation of memfd_create that behaves slightly differently than memfd_create on Linux? -- nosy: +christian.heimes _

[issue41013] test_os.test_memfd_create() fails on AMD64 FreeBSD Shared 3.x

Change by STINNER Victor : -- nosy: +koobs ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pytho

[issue41013] test_os.test_memfd_create() fails on AMD64 FreeBSD Shared 3.x

New submission from STINNER Victor : https://buildbot.python.org/all/#/builders/152/builds/1024 ... test_makedir (test.test_os.MakedirTests) ... ok test_mode (test.test_os.MakedirTests) ... ok Timeout (0:25:00)! Thread 0x000800b54000 (most recent call first): File "/usr/home/buildbot/pyth