[issue41084] Signify that a SyntaxError comes from an fstring in the error message

Lysandros Nikolaou added the comment: Thanks, Victor! The fix is merged, so I'm closing this again. -- ___ Python tracker ___ ___

[issue41084] Signify that a SyntaxError comes from an fstring in the error message

Change by Lysandros Nikolaou : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ __

[issue41084] Signify that a SyntaxError comes from an fstring in the error message

Pablo Galindo Salgado added the comment: New changeset 990efe0fff749773887a50cb1ecb2c5d09263cf8 by Lysandros Nikolaou in branch '3.9': [3.9] bpo-41084: Fix test_fstring failure when using the old parser (GH-21212) https://github.com/python/cpython/commit/990efe0fff749773887a50cb1ecb2c5d09263c

[issue41084] Signify that a SyntaxError comes from an fstring in the error message

Change by Lysandros Nikolaou : -- pull_requests: +20366 stage: resolved -> patch review pull_request: https://github.com/python/cpython/pull/21212 ___ Python tracker ___ __

[issue41084] Signify that a SyntaxError comes from an fstring in the error message

STINNER Victor added the comment: The change broke the old parser in Python 3.9, I reopen the issue: AMD64 Arch Linux VintageParser 3.9: https://buildbot.python.org/all/#/builders/765/builds/129 FAIL: test_format_specifier_expressions (test.test_fstring.TestCase) (str="f'{4:{/5}}'") FAIL: te

[issue41084] Signify that a SyntaxError comes from an fstring in the error message

miss-islington added the comment: New changeset cb0dc52d37a5cc561ad39bc034afe7db9c461768 by Miss Islington (bot) in branch '3.9': bpo-41084: Adjust message when an f-string expression causes a SyntaxError (GH-21084) https://github.com/python/cpython/commit/cb0dc52d37a5cc561ad39bc034afe7db9c4

[issue41084] Signify that a SyntaxError comes from an fstring in the error message

Change by miss-islington : -- nosy: +miss-islington nosy_count: 4.0 -> 5.0 pull_requests: +20342 pull_request: https://github.com/python/cpython/pull/21188 ___ Python tracker _

[issue41084] Signify that a SyntaxError comes from an fstring in the error message

Eric V. Smith added the comment: AFAIK, we don't guarantee the stability of error messages, so I think backporting is fine. It's all the better that this is just prefixing something to an existing error message. -- ___ Python tracker

[issue41084] Signify that a SyntaxError comes from an fstring in the error message

Pablo Galindo Salgado added the comment: I would say yes unless someone sees an obvious impediment -- ___ Python tracker ___ ___ Py

[issue41084] Signify that a SyntaxError comes from an fstring in the error message

Lysandros Nikolaou added the comment: Should we maybe backport this to 3.9 as well? -- ___ Python tracker ___ ___ Python-bugs-list

[issue41084] Signify that a SyntaxError comes from an fstring in the error message

Change by Lysandros Nikolaou : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ __

[issue41084] Signify that a SyntaxError comes from an fstring in the error message

Pablo Galindo Salgado added the comment: New changeset 2e0a920e9eb540654c0bb2298143b00637dc5961 by Lysandros Nikolaou in branch 'master': bpo-41084: Adjust message when an f-string expression causes a SyntaxError (GH-21084) https://github.com/python/cpython/commit/2e0a920e9eb540654c0bb229814

[issue41084] Signify that a SyntaxError comes from an fstring in the error message

Change by Lysandros Nikolaou : -- keywords: +patch pull_requests: +20250 stage: -> patch review pull_request: https://github.com/python/cpython/pull/21084 ___ Python tracker _

[issue41084] Signify that a SyntaxError comes from an fstring in the error message

Lysandros Nikolaou added the comment: > My only reservation would be: if the parsing of f-strings is moved into the > parser, would it be possible to maintain the error new messages? Probably without a single change. -- ___ Python tracker

[issue41084] Signify that a SyntaxError comes from an fstring in the error message

Eric V. Smith added the comment: I think it's a good idea. My only reservation would be: if the parsing of f-strings is moved into the parser, would it be possible to maintain the error new messages? -- ___ Python tracker

[issue41084] Signify that a SyntaxError comes from an fstring in the error message

New submission from Lysandros Nikolaou : It's relatively easy to identify if a SyntaxError occurs when parsing an fstring expression or not. The idea is to slightly change the error message to start with "f-string: " when it does (in the same way in which SyntaxError messages are produced by