[issue4136] merge json library with simplejson 2.0.3

Changes by STINNER Victor : -- nosy: -haypo ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.

[issue4136] merge json library with simplejson 2.0.3

Bob Ippolito added the comment: By "next patch" I'm referring to a currently nonexistent patch that would merge the json library with simplejson 2.0.7 (svn trunk at the moment). I may have time to create it next weekend. --- http://codereview.appspot.com/7311/diff/1/8 File Lib/json/decoder.p

[issue4136] merge json library with simplejson 2.0.3

Martin v. Löwis added the comment: http://codereview.appspot.com/7311/diff/1/8 File Lib/json/decoder.py (right): http://codereview.appspot.com/7311/diff/1/8#newcode55 Line 55: def py_scanstring(s, end, encoding=None, strict=True, _b=BACKSLASH, _m=STRINGCHUNK.match): This function should get som

[issue4136] merge json library with simplejson 2.0.3

Bob Ippolito <[EMAIL PROTECTED]> added the comment: Attached is a new diff, one byte fix to the float parser when parsing JSON documents that are just a float (also a test and a version bump). Added file: http://bugs.python.org/file11870/json_issue4136_r67009.diff _

[issue4136] merge json library with simplejson 2.0.3

Bob Ippolito <[EMAIL PROTECTED]> added the comment: http://codereview.appspot.com/7311 ___ Python tracker <[EMAIL PROTECTED]> ___ ___ Python-bugs

[issue4136] merge json library with simplejson 2.0.3

Bob Ippolito <[EMAIL PROTECTED]> added the comment: I don't recall exactly why they aren't in the struct itself, it may not have worked with some compiler on some platform. It's not really a complete rewrite, the encoding path is largely the same and the tests haven't changed. Anyway, there i

[issue4136] merge json library with simplejson 2.0.3

Martin v. Löwis <[EMAIL PROTECTED]> added the comment: > Actually, if I remove those lines from the equivalent module in simplejson > it no longer works properly with Python 2.5.2. Why aren't the functions pointers in the structs itself? As a procedural note, it seems like this patch is a comp

[issue4136] merge json library with simplejson 2.0.3

Bob Ippolito <[EMAIL PROTECTED]> added the comment: Actually, if I remove those lines from the equivalent module in simplejson it no longer works properly with Python 2.5.2. File "/Users/bob/src/simplejson/simplejson/decoder.py", line 307, in __init__ self.scan_once = make_scanner(self)

[issue4136] merge json library with simplejson 2.0.3

Bob Ippolito <[EMAIL PROTECTED]> added the comment: You're probably right, I don't remember what code I was using as a template for that. ___ Python tracker <[EMAIL PROTECTED]> ___ ___

[issue4136] merge json library with simplejson 2.0.3

Amaury Forgeot d'Arc <[EMAIL PROTECTED]> added the comment: About the patch: are those lines really needed? +PyScannerType.tp_getattro = PyObject_GenericGetAttr; +PyScannerType.tp_setattro = PyObject_GenericSetAttr; +PyScannerType.tp_alloc = PyType_GenericAlloc; +PyScannerType.t

[issue4136] merge json library with simplejson 2.0.3

Bob Ippolito <[EMAIL PROTECTED]> added the comment: patch to r66961 of trunk is attached. -- keywords: +26backport, patch versions: +Python 2.7, Python 3.1 Added file: http://bugs.python.org/file11822/json_issue4136_r66961.diff ___ Python tracker <[EM

[issue4136] merge json library with simplejson 2.0.3

Martin v. Löwis <[EMAIL PROTECTED]> added the comment: > Sure, but that doesn't port it to Python 3.0 :) Still, as Victor suggests, the first step for porting it to 3.0 definitely is to produce a patch for the trunk. What the next steps will be can be discussed when this step has been completed.

[issue4136] merge json library with simplejson 2.0.3

Bob Ippolito <[EMAIL PROTECTED]> added the comment: Sure, but that doesn't port it to Python 3.0 :) ___ Python tracker <[EMAIL PROTECTED]> ___ __

[issue4136] merge json library with simplejson 2.0.3

STINNER Victor <[EMAIL PROTECTED]> added the comment: Can you write a patch against python trunk ? :-) -- nosy: +haypo ___ Python tracker <[EMAIL PROTECTED]> ___ __

[issue4136] merge json library with simplejson 2.0.3

New submission from Bob Ippolito <[EMAIL PROTECTED]>: simplejson 2.0.3 includes major performance enhancements (both in Python and C) and removes usage of the private sre functionality. I will need some help with 3.0 since I am not well versed in the changes to the C API or Python code for tha