[issue41386] Popen.wait does not account for negative return codes

2020-07-27 Thread Eryk Sun
Eryk Sun added the comment: > in the windows API they seam to not know whether to use a ulong or a uint This usage requires C `long int` to be the same size as `int` in 64-bit Windows. -- resolution: -> not a bug ___ Python tracker

[issue41386] Popen.wait does not account for negative return codes

2020-07-25 Thread Nico
Nico added the comment: Yeah I see the point. To me it does make no sense because even in the windows API they seam to not know whether to use a ulong or a uint nor does this reflect the actual depiction within the program. However it is probably not worth implementing a flag for that nor

[issue41386] Popen.wait does not account for negative return codes

2020-07-24 Thread Eryk Sun
Eryk Sun added the comment: In the Windows API, errors and exit status codes are all unsigned 32-bit integers. See SetLastError, GetLastError, ExitThread, ExitProcess, GetExitCodeThread, and GetExitCodeProcess. Even signed NTSTATUS and HRESULT values are commonly displayed as non-negative

[issue41386] Popen.wait does not account for negative return codes

2020-07-24 Thread Nico
Nico added the comment: We apparently need a flag to ensure compatibility with the windows return codes == FAIL: test_disable_windows_exc_handler (test.test_faulthandler.FaultHandlerTests)

[issue41386] Popen.wait does not account for negative return codes

2020-07-24 Thread Nico
Nico added the comment: I don't know if it should be a good idea to add a flag to turn off the negative conversation? -- ___ Python tracker ___

[issue41386] Popen.wait does not account for negative return codes

2020-07-24 Thread Nico
Change by Nico : -- versions: -Python 3.8 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue41386] Popen.wait does not account for negative return codes

2020-07-24 Thread Nico
Change by Nico : -- components: +Library (Lib) -Windows ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue41386] Popen.wait does not account for negative return codes

2020-07-24 Thread Nico
Nico added the comment: I suggest implementing a singed conversation into _wait -- keywords: +patch message_count: 1.0 -> 2.0 pull_requests: +20749 stage: -> patch review pull_request: https://github.com/python/cpython/pull/21607 ___ Python

[issue41386] Popen.wait does not account for negative return codes

2020-07-24 Thread Nico
New submission from Nico : Following problem occurred. A C style program can have negative return codes. However this is not correctly implemented in the Windows API. Therefore it is being returned as unsigned long by the API hence it leads to ambiguity while comparing return codes. For