[issue41410] Opening a file in binary mode makes a difference on all platforms in Python 3

Change by Eric V. Smith : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue41410] Opening a file in binary mode makes a difference on all platforms in Python 3

miss-islington added the comment: New changeset 7c288413db8c2b84dd476b0c8a19f85110d99a2f by Miss Islington (bot) in branch '3.9': bpo-41410: Fix outdated info in mkstemp docs (GH-21701) https://github.com/python/cpython/commit/7c288413db8c2b84dd476b0c8a19f85110d99a2f --

[issue41410] Opening a file in binary mode makes a difference on all platforms in Python 3

miss-islington added the comment: New changeset 2a9f709ba23c8f6aa2bed821aacc4e7baecde383 by Miss Islington (bot) in branch '3.8': bpo-41410: Fix outdated info in mkstemp docs (GH-21701) https://github.com/python/cpython/commit/2a9f709ba23c8f6aa2bed821aacc4e7baecde383 --

[issue41410] Opening a file in binary mode makes a difference on all platforms in Python 3

Change by miss-islington : -- pull_requests: +21000 pull_request: https://github.com/python/cpython/pull/21875 ___ Python tracker ___

[issue41410] Opening a file in binary mode makes a difference on all platforms in Python 3

Change by miss-islington : -- pull_requests: +20998 pull_request: https://github.com/python/cpython/pull/21873 ___ Python tracker ___

[issue41410] Opening a file in binary mode makes a difference on all platforms in Python 3

Change by miss-islington : -- pull_requests: +20999 pull_request: https://github.com/python/cpython/pull/21874 ___ Python tracker ___

[issue41410] Opening a file in binary mode makes a difference on all platforms in Python 3

miss-islington added the comment: New changeset e55de68be3e5b977a17d3c0ac9805b0feff8fedc by Rishav Kundu in branch 'master': bpo-41410: Fix outdated info in mkstemp docs (GH-21701) https://github.com/python/cpython/commit/e55de68be3e5b977a17d3c0ac9805b0feff8fedc -- nosy:

[issue41410] Opening a file in binary mode makes a difference on all platforms in Python 3

Rishav Kundu added the comment: Submitted a PR. Please let me know if I missed something :) -- ___ Python tracker ___ ___

[issue41410] Opening a file in binary mode makes a difference on all platforms in Python 3

Change by Rishav Kundu : -- keywords: +patch nosy: +xrisk nosy_count: 3.0 -> 4.0 pull_requests: +20844 stage: -> patch review pull_request: https://github.com/python/cpython/pull/21701 ___ Python tracker

[issue41410] Opening a file in binary mode makes a difference on all platforms in Python 3

Eric V. Smith added the comment: I think deleting the last sentence is sufficient. -- keywords: +newcomer friendly nosy: +eric.smith ___ Python tracker ___

[issue41410] Opening a file in binary mode makes a difference on all platforms in Python 3

New submission from Bob Kline : The documentation for tempfile.mkstemp() says "If text is specified, it indicates whether to open the file in binary mode (the default) or text mode. On some platforms, this makes no difference." That might have been true for Python 2.x, but in Python 3, there