[issue41744] NuGet python.props only works in python nuget, not other variants

Inada Naoki added the comment: New changeset d0bfce992c4ce0e6e71f13a993c91903a97a62f3 by Miss Skeleton (bot) in branch '3.9': bpo-41744: Package python.props with correct name in NuGet package (GH-22154) https://github.com/python/cpython/commit/d0bfce992c4ce0e6e71f13a993c91903a97a62f3

[issue41744] NuGet python.props only works in python nuget, not other variants

miss-islington added the comment: New changeset b007a9be6fab6d55deae070e5eaef9755794e169 by Miss Islington (bot) in branch '3.8': bpo-41744: Package python.props with correct name in NuGet package (GH-22154) https://github.com/python/cpython/commit/b007a9be6fab6d55deae070e5eaef9755794e169

[issue41744] NuGet python.props only works in python nuget, not other variants

Steve Dower added the comment: Thanks! -- assignee: -> steve.dower resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue41744] NuGet python.props only works in python nuget, not other variants

Steve Dower added the comment: New changeset 7c11a9accabe3720940f334eb1226bb7bb9179c7 by Václav Slavík in branch 'master': bpo-41744: Package python.props with correct name in NuGet package (GH-22154) https://github.com/python/cpython/commit/7c11a9accabe3720940f334eb1226bb7bb9179c7

[issue41744] NuGet python.props only works in python nuget, not other variants

Change by miss-islington : -- pull_requests: +21301 pull_request: https://github.com/python/cpython/pull/22246 ___ Python tracker ___

[issue41744] NuGet python.props only works in python nuget, not other variants

Change by miss-islington : -- nosy: +miss-islington nosy_count: 5.0 -> 6.0 pull_requests: +21300 pull_request: https://github.com/python/cpython/pull/22245 ___ Python tracker

[issue41744] NuGet python.props only works in python nuget, not other variants

Vaclav Slavik added the comment: Sorry for the omission (fixed now), and thanks for your patience! -- ___ Python tracker ___ ___

[issue41744] NuGet python.props only works in python nuget, not other variants

Steve Dower added the comment: Thanks! Just need a NEWS file (click Details next to the failed check for the helper app). Something like "Fixes automatic import of props file when using the Nuget package" would be good. (Also posted on the PR) --

[issue41744] NuGet python.props only works in python nuget, not other variants

Vaclav Slavik added the comment: Thank you, I didn't consider that situation. I forced-pushed an update to the PR now. I opted for duplicate file rather than including, because I think it imposes the least maintenance burden on keeping compatibility: the other alternative would mean - one

[issue41744] NuGet python.props only works in python nuget, not other variants

Change by Steve Dower : -- versions: +Python 3.10, Python 3.8, Python 3.9 ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue41744] NuGet python.props only works in python nuget, not other variants

Steve Dower added the comment: Thanks for the contribution! I think I only ever tested this with the 64-bit package... :) Could you make it so that we include the file under both names? Just for anyone (like me) who has hard-coded the python.props name and parametrised the directory name.

[issue41744] NuGet python.props only works in python nuget, not other variants

Change by Vaclav Slavik : -- keywords: +patch pull_requests: +21233 stage: -> patch review pull_request: https://github.com/python/cpython/pull/22154 ___ Python tracker ___

[issue41744] NuGet python.props only works in python nuget, not other variants

New submission from Vaclav Slavik : NuGet automatically includes .props file from the build directory in the target using the package, but only if the file has the correct name: it must be $(id).props. This means that Python's support for this only works correctly in the python nuget