[issue41950] Typo in Python 3.9 what's new page

Terry J. Reedy added the comment: See #42139 -- nosy: +terry.reedy ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubsc

[issue41950] Typo in Python 3.9 what's new page

Guido van Rossum added the comment: Thanks, merged, so closing. I'll open a separate issue regarding the forward-porting of the 3.9 whatsnew. -- resolution: -> fixed stage: needs patch -> resolved status: open -> closed ___ Python tracker

[issue41950] Typo in Python 3.9 what's new page

Guido van Rossum added the comment: New changeset dc33f798139016961fba33b37c792c690399b2b6 by Weiliang Li in branch '3.9': bpo-41950: Typo in Python 3.9 what's new page (GH-22573) https://github.com/python/cpython/commit/dc33f798139016961fba33b37c792c690399b2b6 -- _

[issue41950] Typo in Python 3.9 what's new page

Weiliang Li added the comment: Thank you, our hardworking BDFL! -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubsc

[issue41950] Typo in Python 3.9 what's new page

Guido van Rossum added the comment: Yeah, I'll see if I can reopen your PR and we can apply it to the 3.9 branch, we'll then forward port it (if and when that's done). -- ___ Python tracker

[issue41950] Typo in Python 3.9 what's new page

Weiliang Li added the comment: No wonder there is discrepancy... So our tactic would be to patch in 3.9 branch and bring it back to master? -- ___ Python tracker ___

[issue41950] Typo in Python 3.9 what's new page

Guido van Rossum added the comment: Oh, I see. Łukasz (@ambv) prepared the 3.9.0 release and didn't merge his changes into master yet. I'll contact him. -- nosy: +lukasz.langa ___ Python tracker ___

[issue41950] Typo in Python 3.9 what's new page

Weiliang Li added the comment: The diff is here: https://gist.github.com/kigawas/c0c3900e5f56552f13160c7989612c28 Looks like it is not trivial. And the commit at branch 3.9 is: https://github.com/python/cpython/commit/9cf6752276e6fcfd0c23fdb064ad27f448aaaf75#diff-ec874d66bbcf13046b9928aa371

[issue41950] Typo in Python 3.9 what's new page

Guido van Rossum added the comment: There really shouldn't be any differences between that doc in the 3.9 and master branch (with rare exceptions). Can you post a diff here between the two so we can sort it out? Also can you find the commit where it was added to the 3.9 branch? --

[issue41950] Typo in Python 3.9 what's new page

Weiliang Li added the comment: The whole CONTAINS_OP stuff is gone in master, but it's still there in 3.9 branch. I don't know why. Any plan to resolve the discrepancy? -- ___ Python tracker _

[issue41950] Typo in Python 3.9 what's new page

Guido van Rossum added the comment: Hm, I guess my repo is out of date. Sorry. So it is in master? Let's fix it there then. -- resolution: out of date -> stage: resolved -> needs patch status: closed -> open versions: +Python 3.10 ___ Python track

[issue41950] Typo in Python 3.9 what's new page

Weiliang Li added the comment: And the "What’s New In Python 3.9" page (updated today): https://docs.python.org/3/whatsnew/3.9.html#cpython-bytecode-changes -- ___ Python tracker ___

[issue41950] Typo in Python 3.9 what's new page

Weiliang Li added the comment: It's here https://github.com/python/cpython/blob/3.9/Doc/whatsnew/3.9.rst#cpython-bytecode-changes Just several pixels below -- ___ Python tracker ___

[issue41950] Typo in Python 3.9 what's new page

Guido van Rossum added the comment: Honestly I don't see it in the 3.9 branch either. It seems the whole section mentioned in the closed PR doesn't exist anywhere. Maybe it was reverted for some reason. Let's close this issue. -- resolution: -> out of date stage: patch review -> res

[issue41950] Typo in Python 3.9 what's new page

Weiliang Li added the comment: Well, it looks like there is no CONTAINS_OP part under the subtitle "CPython bytecode changes" in master's Doc/whatsnew/3.9.rst Maybe it's some discrepancy? -- ___ Python tracker

[issue41950] Typo in Python 3.9 what's new page

Guido van Rossum added the comment: All this needs is a PR filed against latest master that updates Doc/whatsnew/3.9.rst and labeled with needs-backport-3.9. -- nosy: +gvanrossum ___ Python tracker

[issue41950] Typo in Python 3.9 what's new page

Change by Weiliang Li : -- keywords: +patch pull_requests: +21568 stage: -> patch review pull_request: https://github.com/python/cpython/pull/22573 ___ Python tracker ___

[issue41950] Typo in Python 3.9 what's new page

New submission from Weiliang Li : CONTAINS_OP for ‘in’ and ‘is not’ tests should be CONTAINS_OP for ‘in’ and ‘not in’ tests Ref: https://bugs.python.org/issue39156 -- assignee: docs@python components: Documentation messages: 378085 nosy: docs@python, kigawas priority: normal severity