[issue42037] Documentation confusion in CookieJar functions

2021-04-15 Thread Andrei Kulakov
Andrei Kulakov added the comment: I can confirm `unverifiable` is an attr: https://github.com/python/cpython/blob/master/Lib/urllib/request.py#L333 and so is incorrectly listed as a method in cookie jar docs. -- nosy: +andrei.avk ___ Python tracke

[issue42037] Documentation confusion in CookieJar functions

2020-11-02 Thread Roundup Robot
Change by Roundup Robot : -- keywords: +patch nosy: +python-dev nosy_count: 3.0 -> 4.0 pull_requests: +22029 stage: -> patch review pull_request: https://github.com/python/cpython/pull/23112 ___ Python tracker _

[issue42037] Documentation confusion in CookieJar functions

2020-11-02 Thread Markus Israelsson
Markus Israelsson added the comment: I am currently updating the documentation source code. On the cookiejar page it describes 'unverifiable' as a method. I can however not find that method on the request page because it seems to be just a normal attribute. I will make updates for that as wel

[issue42037] Documentation confusion in CookieJar functions

2020-10-22 Thread Éric Araujo
Éric Araujo added the comment: Yes, you will need a github account linked to a bpo (this site) account so that the contributor agreement bot can do its job. -- ___ Python tracker

[issue42037] Documentation confusion in CookieJar functions

2020-10-21 Thread Markus Israelsson
Markus Israelsson added the comment: I got ok from the higherups. Will plan this into next sprint so it will take a week or 2 before I get to it. -- ___ Python tracker ___ ___

[issue42037] Documentation confusion in CookieJar functions

2020-10-21 Thread Markus Israelsson
Markus Israelsson added the comment: I guess due to something having to be signed I would have to create a personal github account :/ -- ___ Python tracker ___ __

[issue42037] Documentation confusion in CookieJar functions

2020-10-21 Thread Markus Israelsson
Markus Israelsson added the comment: Sure. But I will need to get an ok from my company to spend some time on this because I really am not very used to git yet (recently switched). Also, is it possible to make the request/changes through the company github account or must that in that case

[issue42037] Documentation confusion in CookieJar functions

2020-10-20 Thread Éric Araujo
Éric Araujo added the comment: Ah, I see it now: get_host and get_type are in both lists! Would you like to contribute a fix for the docs? If yes, help is here: https://devguide.python.org/docquality/ -- ___ Python tracker

[issue42037] Documentation confusion in CookieJar functions

2020-10-19 Thread Markus Israelsson
Markus Israelsson added the comment: The way I read the documentation for add_cookie_header is: These methods must exist in the Request object: - get_full_url() - get_host() - get_type() - unverifiable... and so on. The documentation for the request objects claims however that: These methods

[issue42037] Documentation confusion in CookieJar functions

2020-10-19 Thread Éric Araujo
Éric Araujo added the comment: Hello! I don’t see the problem that you are mentioning: the request methods removed from Request objects are not in the list of methods required by the CookieJar methods. -- nosy: +eric.araujo ___ Python tracker

[issue42037] Documentation confusion in CookieJar functions

2020-10-14 Thread Markus Israelsson
New submission from Markus Israelsson : The documentation in https://docs.python.org/3.8/library/http.cookiejar.html#http.cookiejar.CookieJar claims the following for functions add_cookie_header and extract_cookies. *** The request object (usually a urllib.request.Request instance) must suppor