[issue42053] fwalk: incorrect boolean test for non-fd arguments

Change by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: +Python 3.11 -Python 3.9 ___ Python tracker ___

[issue42053] fwalk: incorrect boolean test for non-fd arguments

Serhiy Storchaka added the comment: New changeset 2b496e79293a8b80e8ba0e514e186b3b1467b64b by Serhiy Storchaka in branch 'main': bpo-42053: Remove misleading check in os.fwalk() (GH-27669) https://github.com/python/cpython/commit/2b496e79293a8b80e8ba0e514e186b3b1467b64b --

[issue42053] fwalk: incorrect boolean test for non-fd arguments

Change by Serhiy Storchaka : -- pull_requests: +26158 pull_request: https://github.com/python/cpython/pull/27669 ___ Python tracker ___

[issue42053] fwalk: incorrect boolean test for non-fd arguments

Serhiy Storchaka added the comment: I confirm that fwalk() does not support integer first argument. This check is misleading. -- nosy: +serhiy.storchaka ___ Python tracker

[issue42053] fwalk: incorrect boolean test for non-fd arguments

Change by Hasan : -- pull_requests: -26038 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue42053] fwalk: incorrect boolean test for non-fd arguments

Change by Hasan : -- pull_requests: +26039 pull_request: https://github.com/python/cpython/pull/27524 ___ Python tracker ___ ___

[issue42053] fwalk: incorrect boolean test for non-fd arguments

Change by Hasan : -- keywords: +patch nosy: +AliyevH nosy_count: 2.0 -> 3.0 pull_requests: +26038 stage: -> patch review pull_request: https://github.com/python/cpython/pull/27523 ___ Python tracker

[issue42053] fwalk: incorrect boolean test for non-fd arguments

Andrei Kulakov added the comment: By the way I confirmed that fixing this doesn't break any tests (perhaps unsurprising ;) ) -- ___ Python tracker ___

[issue42053] fwalk: incorrect boolean test for non-fd arguments

Andrei Kulakov added the comment: dubiousjim: I agree, it should be `and` or have the form `not (isinstance(..) or hasattr(..))`. If you would like to make the patch, I can review. -- nosy: +andrei.avk ___ Python tracker

[issue42053] fwalk: incorrect boolean test for non-fd arguments

New submission from dubiousjim : `Lib/os.py` has at line 464, in definition of `fwalk`: ``` if not isinstance(top, int) or not hasattr(top, '__index__'): ``` If I understand this test correctly, it should be requiring that the name/fd is NEITHER an int NOR has an __index__ method. As