[issue42206] Pegen: Raise errors occurred by the AST validator

Change by Batuhan Taskaya : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ _

[issue42206] Pegen: Raise errors occurred by the AST validator

Pablo Galindo Salgado added the comment: New changeset 3af4b585527743e455145d294049c46b7c823ed9 by Batuhan Taskaya in branch 'master': bpo-42206: Propagate and raise errors from PyAST_Validate in the parser (GH-23035) https://github.com/python/cpython/commit/3af4b585527743e455145d294049c46b7

[issue42206] Pegen: Raise errors occurred by the AST validator

Pablo Galindo Salgado added the comment: > This will slow down the parser massively. The reason we went' with the assert > is so we only do the check in debug mode. We could propagate if you want, but > it needs to be surrounded by debug preprocessor checks. Oh, I just checked and it current

[issue42206] Pegen: Raise errors occurred by the AST validator

Pablo Galindo Salgado added the comment: This will slow down the parser massively. The reason we went' with the assert is so we only do the check in debug mode. We could propagate if you want, but it needs to be surrounded by debug preprocessor checks. -- ___

[issue42206] Pegen: Raise errors occurred by the AST validator

Change by Batuhan Taskaya : -- keywords: +patch pull_requests: +21954 stage: -> patch review pull_request: https://github.com/python/cpython/pull/23035 ___ Python tracker ___

[issue42206] Pegen: Raise errors occurred by the AST validator

New submission from Batuhan Taskaya : When working on the AST validator, it is unclear that which of the changes caused parser to fail on valid input. I propose to propagate the error and raise it. Current: $ ./python t.py python: Parser/pegen.c:1146: _PyPegen_run_parser: Assertion `PyAST_Va