[issue42237] test_socket.SendfileUsingSendfileTest fails on illumos

Change by Andrew Svetlov : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: +Python 3.8 ___ Python tracker ___

[issue42237] test_socket.SendfileUsingSendfileTest fails on illumos

Andrew Svetlov added the comment: New changeset f37628eb7117f222de24a6931aa7639e668cb7b0 by Jakub Stasiak in branch '3.8': [3.8] bpo-42237: Fix os.sendfile() on illumos (GH-23154). (GH-23246) https://github.com/python/cpython/commit/f37628eb7117f222de24a6931aa7639e668cb7b0 --

[issue42237] test_socket.SendfileUsingSendfileTest fails on illumos

Change by Jakub Stasiak : -- pull_requests: +22143 pull_request: https://github.com/python/cpython/pull/23246 ___ Python tracker ___

[issue42237] test_socket.SendfileUsingSendfileTest fails on illumos

miss-islington added the comment: New changeset 7ae19ef5cf5d4f464588133bd48f81d80ea54aee by Miss Islington (bot) in branch '3.9': bpo-42237: Fix os.sendfile() on illumos (GH-23154) https://github.com/python/cpython/commit/7ae19ef5cf5d4f464588133bd48f81d80ea54aee --

[issue42237] test_socket.SendfileUsingSendfileTest fails on illumos

Change by miss-islington : -- nosy: +miss-islington nosy_count: 4.0 -> 5.0 pull_requests: +22141 pull_request: https://github.com/python/cpython/pull/23244 ___ Python tracker

[issue42237] test_socket.SendfileUsingSendfileTest fails on illumos

Andrew Svetlov added the comment: New changeset fd4ed57674c675e05bd5d577dd5047a333c76c78 by Jakub Stasiak in branch 'master': bpo-42237: Fix os.sendfile() on illumos (GH-23154) https://github.com/python/cpython/commit/fd4ed57674c675e05bd5d577dd5047a333c76c78 -- nosy: +asvetlov

[issue42237] test_socket.SendfileUsingSendfileTest fails on illumos

Change by Jakub Kulik : -- versions: +Python 3.9 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue42237] test_socket.SendfileUsingSendfileTest fails on illumos

Jakub Stasiak added the comment: Thank you! I submitted a PR with a slightly modified patch (the comparison only happens on Solaris family of systems), I'd appreciate your confirmation that it still works (it's working for me on openindiana). --

[issue42237] test_socket.SendfileUsingSendfileTest fails on illumos

Change by Jakub Stasiak : -- pull_requests: +22066 pull_request: https://github.com/python/cpython/pull/23154 ___ Python tracker ___

[issue42237] test_socket.SendfileUsingSendfileTest fails on illumos

Jakub Kulik added the comment: I did some further digging, and this is indeed not possible on Oracle Solaris (that is, sendfile() cannot write bytes and fail during the same call). We considered this a bug and changed/fixed it several years ago. Manual page doesn't mention that either:

[issue42237] test_socket.SendfileUsingSendfileTest fails on illumos

Sebastian Wiedenroth added the comment: Excellent analysis, that's it! I've also tested your patch on SmartOS and it works great. -- ___ Python tracker ___

[issue42237] test_socket.SendfileUsingSendfileTest fails on illumos

Jakub Stasiak added the comment: I thought I'd give it a shot and I believe i found the issue. Let's use the testCount test as an example. The client side (or the data sending side) looks like this: def _testCount(self): address = self.serv.getsockname() file =

[issue42237] test_socket.SendfileUsingSendfileTest fails on illumos

Change by Sebastian Wiedenroth : -- keywords: +patch pull_requests: +22002 stage: -> patch review pull_request: https://github.com/python/cpython/pull/23085 ___ Python tracker

[issue42237] test_socket.SendfileUsingSendfileTest fails on illumos

New submission from Sebastian Wiedenroth : I'm investigating some test failures related to sendfile on illumos: testCount (test.test_socket.SendfileUsingSendfileTest) ... FAIL testCountSmall (test.test_socket.SendfileUsingSendfileTest) ... ok testCountWithOffset