[issue42269] Add ability to set __slots__ in dataclasses

Eric V. Smith added the comment: Thanks for all of your work, Yurii. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue42269] Add ability to set __slots__ in dataclasses

Eric V. Smith added the comment: New changeset c24199184bea0c851c1a7296ae54aaf18ee56752 by Yurii Karabas in branch 'master': bpo-42269: Add slots parameter to dataclass decorator (GH-24171) https://github.com/python/cpython/commit/c24199184bea0c851c1a7296ae54aaf18ee56752 --

[issue42269] Add ability to set __slots__ in dataclasses

Change by Paul Bryan : -- nosy: +pbryan ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue42269] Add ability to set __slots__ in dataclasses

Yurii Karabas <1998uri...@gmail.com> added the comment: Hi Eric, I tried to help you with this feature and have opened a PR. I thought that you are too busy to implement this feature, so that's why I decided to help you (It almost two months since your last message in this thread).

[issue42269] Add ability to set __slots__ in dataclasses

Change by Yurii Karabas <1998uri...@gmail.com>: -- keywords: +patch nosy: +uriyyo nosy_count: 5.0 -> 6.0 pull_requests: +22998 stage: -> patch review pull_request: https://github.com/python/cpython/pull/24171 ___ Python tracker

[issue42269] Add ability to set __slots__ in dataclasses

Change by lcy : -- nosy: +lcy0321 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue42269] Add ability to set __slots__ in dataclasses

Change by Xtrem532 : -- nosy: +Xtrem532 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue42269] Add ability to set __slots__ in dataclasses

Jakub Stasiak added the comment: As a moderately-heavy dataclass user I support this. :) -- ___ Python tracker ___ ___

[issue42269] Add ability to set __slots__ in dataclasses

Eric V. Smith added the comment: It would figure it out automatically. See https://github.com/ericvsmith/dataclasses/blob/master/dataclass_tools.py for a decorator that already does this. I'll have a PR ready soon, I hope. -- ___ Python tracker

[issue42269] Add ability to set __slots__ in dataclasses

Josh Rosenberg added the comment: Is the plan to allow an argument to auto-generate __slots__, or would this require repeating the names once in __slots__, and once for annotations and the like? -- ___ Python tracker

[issue42269] Add ability to set __slots__ in dataclasses

Change by Josh Rosenberg : -- nosy: +josh.r ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue42269] Add ability to set __slots__ in dataclasses

Change by Jakub Stasiak : -- nosy: +jstasiak ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue42269] Add ability to set __slots__ in dataclasses

New submission from Eric V. Smith : I resisted adding the ability to set __slots__ in the first version of dataclasses, since it requires that instead of modifying an existing class, an entirely new class is returned. But I think this feature would be useful enough that I'm now willing to