R. David Murray added the comment:
Looks to like there is nothing left to do here, so I'm closing it.
--
resolution: - fixed
stage: commit review - resolved
status: open - closed
___
Python tracker rep...@bugs.python.org
R. David Murray added the comment:
Thanks for updating.
In the doc change you say it updates environment variables, but in the whatsnew
change you say it changes constants of the curses module. I believe the whats
new version is correct? Also, doc lines should be wrapped to 80 columns.
Arnon Yaari added the comment:
Fixed David's comments
--
versions: +Python 3.5 -Python 3.2
Added file: http://bugs.python.org/file39037/issue4254.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4254
Changes by Arnon Yaari wiggi...@gmail.com:
Removed file: http://bugs.python.org/file38973/patch_4254.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4254
___
Arnon Yaari added the comment:
I'm adding patch without the update to Misc/NEWS.
I'm not sure why, but the curses doc refers to LINES and COLS as environment
variables. In the doc change I referred to them as just variables and used
the notation that works for linking to them, using :envvar:
Arnon Yaari added the comment:
Adding a test that only calls the function.
--
Added file: http://bugs.python.org/file39048/issue4254-2.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4254
Steve Dower added the comment:
Arnon has signed the CLA at PyCon, it just hasn't been processed yet.
--
stage: patch review - commit review
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4254
Roundup Robot added the comment:
New changeset 132b5376bf34 by Steve Dower in branch 'default':
Issue #4254: Adds _curses.update_lines_cols() Patch by Arnon Yaari
https://hg.python.org/cpython/rev/132b5376bf34
--
nosy: +python-dev
___
Python tracker
Steve Dower added the comment:
Arnon - we'll need you to fill out
https://www.python.org/psf/contrib/contrib-form/ before we can merge this patch
in. (The dev guide isn't clear on whether trivial patches are okay, but the
advice I was given is that we should have a CLA for everything.)
R. David Murray added the comment:
Thanks for the patch update.
The doc addition needs a .. versionadded directive, and there should be an
entry in the 3.5 whatsnew document.
--
nosy: +r.david.murray
___
Python tracker rep...@bugs.python.org
Changes by Ned Deily n...@acm.org:
--
nosy: +twouters
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4254
___
___
Python-bugs-list mailing list
Arnon Yaari added the comment:
Creating an automatic test for this issue proves difficult, as using curses to
resize the terminal already updates the values, and using ioctls to try to
bypass curses, doesn't work.
I'm adding a manual test program (mostly taken from
Changes by Arnon Yaari wiggi...@gmail.com:
Added file: http://bugs.python.org/file38971/manual_test_4254.py
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4254
___
Changes by Arnon Yaari wiggi...@gmail.com:
Added file: http://bugs.python.org/file38973/patch_4254.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4254
___
Changes by A.M. Kuchling a...@amk.ca:
--
nosy: -akuchling
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4254
___
___
Python-bugs-list mailing
Changes by Mark Lawrence breamore...@yahoo.co.uk:
--
nosy: -BreamoreBoy
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4254
___
___
Changes by A.M. Kuchling li...@amk.ca:
--
assignee: akuchling -
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4254
___
___
Python-bugs-list
Mark Lawrence breamore...@yahoo.co.uk added the comment:
msg82783 states code portion of patch looks ok, what do we need to take this
forward?
--
nosy: +BreamoreBoy
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4254
Changes by Terry J. Reedy tjre...@udel.edu:
--
stage: - patch review
versions: +Python 3.2 -Python 2.5
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4254
___
Changes by STINNER Victor victor.stin...@haypocalc.com:
--
nosy: -haypo
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4254
___
___
A.M. Kuchling li...@amk.ca added the comment:
No documentation? Doc/library/curses.rst exists; there's also
Doc/howto/curses.rst. What functions in _curses need to be documented?
--
nosy: +akuchling
___
Python tracker rep...@bugs.python.org
A.M. Kuchling li...@amk.ca added the comment:
BTW, the code portion of the patch looks OK to me.
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4254
___
___
New submission from Roland Brickl [EMAIL PROTECTED]:
curses.update_lines.cols() are normally usable within c programs. With
this change, it can now be used too. It only calls the preexisting
function that where only used internally. The cast in the return
statement are possibly false? But it
STINNER Victor [EMAIL PROTECTED] added the comment:
Your function PyCurses_update_lines_cols() has no documentation. Can
you add it?
Can you also give an use case of update_lines_cols()? The function is
already called by curses.resizeterm() and curses.resize_term().
--
nosy: +haypo
Roland Brickl [EMAIL PROTECTED] added the comment:
Hi Victor,
i use this to get updated versions of curses.COLS and curses.LINES in
the fact of an curses.KEY_RESIZE event.
So i can use curses within python even without to have panels.
It seems that curses.panel are the prefered way to deal
STINNER Victor [EMAIL PROTECTED] added the comment:
i use this to get updated versions of curses.COLS and curses.LINES in
the fact of an curses.KEY_RESIZE event.
I didn't know this event. Is a key in a special keyboard? Or an event raised
by some curses internals?
Updates curses.LINES and
Roland Brickl [EMAIL PROTECTED] added the comment:
i use this to get updated versions of curses.COLS and curses.LINES in
the fact of an curses.KEY_RESIZE event.
I didn't know this event. Is a key in a special keyboard? Or an event
raised
by some curses internals?
Internal curses event.
Oh
27 matches
Mail list logo
