[issue42574] Travis can't build the 3.8 branch right now

Change by Pablo Galindo Salgado : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___

[issue42574] Travis can't build the 3.8 branch right now

Pablo Galindo Salgado added the comment: New changeset b6d6f5367da1f2e3f749c358ae8563c56a0cc395 by Pablo Galindo in branch '3.8': bpo-42574: Use format() instead of f-string in Tools/clinic/clinic.py to allow using older Python versions (GH-23685) https://github.com/python/cpython/commit/b6d

[issue42574] Travis can't build the 3.8 branch right now

Change by Pablo Galindo Salgado : -- pull_requests: +22548 pull_request: https://github.com/python/cpython/pull/23685 ___ Python tracker ___ ___

[issue42574] Travis can't build the 3.8 branch right now

Pablo Galindo Salgado added the comment: I would suggest to use some other string formatting for that one line. The reason is that technically (although very unlikely) downstream consumers could be relying on some old PYTHON_FOR_REGEN in the Makefile for 3.8 and I would not like to change th

[issue42574] Travis can't build the 3.8 branch right now

Ammar Askar added the comment: Oh whoops, got sniped by Brandt while investigating :) -- ___ Python tracker ___ ___ Python-bugs-lis

[issue42574] Travis can't build the 3.8 branch right now

Ammar Askar added the comment: >From a quick glance at >https://github.com/python/cpython/pulls?page=2&q=base%3A3.8+-label%3Atype-documentation It looks like travis on 3.8 last passed at https://github.com/python/cpython/pull/23364 around 19 days ago The culprit commit is likely https://gi

[issue42574] Travis can't build the 3.8 branch right now

Brandt Bucher added the comment: So I suppose we can either: - set PYTHON_FOR_REGEN to something 3.6+ on these backport branches - use some other string formatting for that one line I sort of prefer the second, since I *think* this is the only thing keeping older Pythons from working here.

[issue42574] Travis can't build the 3.8 branch right now

Brandt Bucher added the comment: It has been failing for some time. It's just not a required check, so it's easy to miss on a backport branch. I think the addition of an f-string in PR 23371 a few weeks ago is what started making this fail (since the system python can't run clinic anymore).

[issue42574] Travis can't build the 3.8 branch right now

Pablo Galindo Salgado added the comment: I am a bit confusedwhy is this failing now? -- ___ Python tracker ___ ___ Python-bugs-

[issue42574] Travis can't build the 3.8 branch right now

Brandt Bucher added the comment: Pablo, maybe you can shed some light on this. It looks like the PEG parser PR explicitly sets PYTHON_FOR_REGEN=python3.8 using pyenv in .travis.yml for the master (and now 3.9) branches. The change was made in the we-like-parsers repo here: https://github.co

[issue42574] Travis can't build the 3.8 branch right now

Change by Brandt Bucher : -- keywords: +patch pull_requests: +22522 stage: -> patch review pull_request: https://github.com/python/cpython/pull/23652 ___ Python tracker ___ __

[issue42574] Travis can't build the 3.8 branch right now

New submission from Brandt Bucher : Travis seems to be using the wrong Python executable for (at least) the "make -j4 regen-all" step on the 3.8 branch. I have a hunch it's using the system python3 executable (3.5?). It causes the following failure when building: ... python3 ./Tools/scripts/u