[issue42673] Optimize round_size for rehashing

Andrei Kulakov added the comment: Closing as it sounds like OP agreed to it in the last msg; and no benchmarking was provided. -- nosy: +andrei.avk resolution: -> rejected stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue42673] Optimize round_size for rehashing

Jurjen N.E. Bos added the comment: Harsh, but fair. I'll do a better job next time! Op di 29 dec. 2020 13:42 schreef Serhiy Storchaka : > > Serhiy Storchaka added the comment: > > Since no benchmarking data was provided, I suggest to close this issue. We > do not accept optimization changes

[issue42673] Optimize round_size for rehashing

Serhiy Storchaka added the comment: Since no benchmarking data was provided, I suggest to close this issue. We do not accept optimization changes without evidences of performance boost. -- status: open -> pending ___ Python tracker

[issue42673] Optimize round_size for rehashing

Jakub Stasiak added the comment: I'd be especially curious about branch (mis)prediction stats before and after applying this patch – including such information seems necessary in a patch that's about optimization. -- nosy: +jstasiak ___ Python

[issue42673] Optimize round_size for rehashing

Serhiy Storchaka added the comment: Do you have any benchmarks? -- nosy: +serhiy.storchaka ___ Python tracker ___ ___

[issue42673] Optimize round_size for rehashing

Change by Jurjen N.E. Bos : -- keywords: +patch pull_requests: +22692 stage: -> patch review pull_request: https://github.com/python/cpython/pull/23833 ___ Python tracker ___

[issue42673] Optimize round_size for rehashing

New submission from Jurjen N.E. Bos : There's a trivial optimization in the round_size in hashtable.c: a loop is used to compute the lowest power of two >= s, while this can be done in one step with bit_length. I am making a pull request for this. -- components: Interpreter Core