[issue43030] signed/unsigned mismatch in Py_UNICODE_ISSPACE macro

Change by Serhiy Storchaka : -- components: +C API -Extension Modules resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: +Python 3.10, Python 3.8 ___ Python tracker

[issue43030] signed/unsigned mismatch in Py_UNICODE_ISSPACE macro

Serhiy Storchaka added the comment: New changeset 229ef39bcc14ee7838968dfda51d045304e5cf39 by Miss Islington (bot) in branch '3.8': bpo-43030: Fixed a compiler warning in Py_UNICODE_ISSPACE with signed wchar_t (GH-24350) (GH-24397)

[issue43030] signed/unsigned mismatch in Py_UNICODE_ISSPACE macro

miss-islington added the comment: New changeset 995a6c015024f050b99ba8f9837dfc6b82d83f7d by Miss Islington (bot) in branch '3.9': bpo-43030: Fixed a compiler warning in Py_UNICODE_ISSPACE with signed wchar_t (GH-24350)

[issue43030] signed/unsigned mismatch in Py_UNICODE_ISSPACE macro

Change by miss-islington : -- pull_requests: +23211 pull_request: https://github.com/python/cpython/pull/24397 ___ Python tracker ___

[issue43030] signed/unsigned mismatch in Py_UNICODE_ISSPACE macro

Change by miss-islington : -- nosy: +miss-islington nosy_count: 4.0 -> 5.0 pull_requests: +23210 pull_request: https://github.com/python/cpython/pull/24396 ___ Python tracker

[issue43030] signed/unsigned mismatch in Py_UNICODE_ISSPACE macro

Serhiy Storchaka added the comment: New changeset 42b1806af90b86ec393ca7da14e99ce95ec6c53b by Serhiy Storchaka in branch 'master': bpo-43030: Fixed a compiler warning in Py_UNICODE_ISSPACE with signed wchar_t (GH-24350)

[issue43030] signed/unsigned mismatch in Py_UNICODE_ISSPACE macro

Serhiy Storchaka added the comment: No, it is not enough, because we do not want to use ch as index if it is negative. -- ___ Python tracker ___

[issue43030] signed/unsigned mismatch in Py_UNICODE_ISSPACE macro

Change by Serhiy Storchaka : -- keywords: +patch nosy: +serhiy.storchaka nosy_count: 3.0 -> 4.0 pull_requests: +23170 stage: -> patch review pull_request: https://github.com/python/cpython/pull/24350 ___ Python tracker

[issue43030] signed/unsigned mismatch in Py_UNICODE_ISSPACE macro

Inada Naoki added the comment: Just replacing "128U" with "128" enough? Will `ch < 128` emit warning on platforms wchar_t is unsigned? -- ___ Python tracker ___

[issue43030] signed/unsigned mismatch in Py_UNICODE_ISSPACE macro

Matthias Klose added the comment: # 26 "/usr/include/stdlib.h" 2 3 4 # 1 "/usr/lib/gcc/x86_64-linux-gnu/10/include/stddef.h" 1 3 4 # 321 "/usr/lib/gcc/x86_64-linux-gnu/10/include/stddef.h" 3 4 typedef int wchar_t; # 32 "/usr/include/stdlib.h" 2 3 4 [...] # 1

[issue43030] signed/unsigned mismatch in Py_UNICODE_ISSPACE macro

STINNER Victor added the comment: > ‘Py_UNICODE’ {aka ‘int’} Python defines Py_UNICODE as wchar_t: typedef wchar_t Py_UNICODE; Is wchar_t signed (int type) on Debian? Which is your architecture? > [forwarded from https://bugs.debian.org/961396] It says amd64. -- nosy: +methane,

[issue43030] signed/unsigned mismatch in Py_UNICODE_ISSPACE macro

New submission from Matthias Klose : [forwarded from https://bugs.debian.org/961396] $ cat > foo.c #include int main(int argc, char *argv[]) { Py_UNICODE x = 0; return Py_UNICODE_ISSPACE(x); } $ gcc -Wsign-compare -Werror $(pkg-config --cflags python3) foo.c In file included