[issue43060] Convert _decimal C API from pointer array to struct

Erlend Egeberg Aasland added the comment: Closing, as the C API was removed in GH-24960. -- resolution: -> out of date stage: -> resolved status: open -> closed ___ Python tracker

[issue43060] Convert _decimal C API from pointer array to struct

Mark Dickinson added the comment: Just a note that #43422 would make this moot. -- nosy: +mark.dickinson ___ Python tracker ___

[issue43060] Convert _decimal C API from pointer array to struct

hai shi added the comment: > True. Is there many external users of this API? I could not find any relevant > examples using searchcode.com. Hm, many teams don't open their code, so we get check all user cases by searchcode web. So I have no any better sugesstion about it :( --

[issue43060] Convert _decimal C API from pointer array to struct

Erlend Egeberg Aasland added the comment: > But converting the decimal c api may breaks the compatibility, because some > macros like `PyDec_TypeCheck_INDEX` have been exposed in headers. True. Is there many external users of this API? I could not find any relevant examples using

[issue43060] Convert _decimal C API from pointer array to struct

hai shi added the comment: > It is not "bad"; it is just more wordy. Agree. Using sturct will be more easy check the members. But converting the decimal c api may breaks the compatibility, because some macros like `PyDec_TypeCheck_INDEX` have been exposed in headers. --

[issue43060] Convert _decimal C API from pointer array to struct

Antoine Pitrou added the comment: I have no opinion about *adding* a struct, but we shouldn't remove the existing array of pointers, or this will needlessly break compatibility for existing users of the C API. -- nosy: +pitrou ___ Python tracker

[issue43060] Convert _decimal C API from pointer array to struct

Raymond Hettinger added the comment: > In my opinion, an array of pointers is a bad API; The existing code is how types were made for most of Python's history. It is not "bad"; it is just more wordy. Given that the current code is correct, I don't see any strong reason to churn the code.

[issue43060] Convert _decimal C API from pointer array to struct

Change by Mark Dickinson : -- nosy: -mark.dickinson ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue43060] Convert _decimal C API from pointer array to struct

Erlend Egeberg Aasland added the comment: In my opinion, an array of pointers is a bad API; using a struct (like most of the other API's) is an improvement. Ref. discussions on GH-24186 (https://github.com/python/cpython/pull/24186#discussion_r560834060) and bpo-43009. --

[issue43060] Convert _decimal C API from pointer array to struct

Mark Dickinson added the comment: Can you explain what problem this would be solving? -- ___ Python tracker ___ ___

[issue43060] Convert _decimal C API from pointer array to struct

Change by Raymond Hettinger : -- nosy: -rhettinger ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue43060] Convert _decimal C API from pointer array to struct

Change by Serhiy Storchaka : -- nosy: +facundobatista, mark.dickinson, rhettinger, skrah ___ Python tracker ___ ___

[issue43060] Convert _decimal C API from pointer array to struct

Change by Erlend Egeberg Aasland : -- type: -> enhancement ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue43060] Convert _decimal C API from pointer array to struct

New submission from Erlend Egeberg Aasland : Ref. discussions on bpo-43009 and bpo-41798. -- components: Library (Lib) messages: 385901 nosy: erlendaasland, shihai1991, vstinner priority: normal severity: normal status: open title: Convert _decimal C API from pointer array to struct