[issue43174] Windows: Use /utf-8 compiler flag

Change by Inada Naoki : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: +Python 3.9 ___ Python tracker ___ ___

[issue43174] Windows: Use /utf-8 compiler flag

Inada Naoki added the comment: New changeset 68d6bc798b34eccabdfbf94e563273759c4cef1f by Miss Islington (bot) in branch '3.9': bpo-43174: Windows: Use /utf-8 compiler option. (GH-24498) https://github.com/python/cpython/commit/68d6bc798b34eccabdfbf94e563273759c4cef1f -- ___

[issue43174] Windows: Use /utf-8 compiler flag

Change by miss-islington : -- nosy: +miss-islington nosy_count: 5.0 -> 6.0 pull_requests: +23299 pull_request: https://github.com/python/cpython/pull/24513 ___ Python tracker _

[issue43174] Windows: Use /utf-8 compiler flag

Steve Dower added the comment: I think so, yeah. We shouldn't have any string literals that are non-ASCII, but if we do then it's almost certainly an improvement for them to be UTF-8. -- ___ Python tracker

[issue43174] Windows: Use /utf-8 compiler flag

Inada Naoki added the comment: May I backport this for Python 3.9? -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsu

[issue43174] Windows: Use /utf-8 compiler flag

Inada Naoki added the comment: New changeset fedd86df2448370cdf62a229fd6f31dc92daf379 by Inada Naoki in branch 'master': bpo-43174: Windows: Use /utf-8 compiler option. (GH-24498) https://github.com/python/cpython/commit/fedd86df2448370cdf62a229fd6f31dc92daf379 -- _

[issue43174] Windows: Use /utf-8 compiler flag

Change by Inada Naoki : -- keywords: +patch pull_requests: +23287 stage: -> patch review pull_request: https://github.com/python/cpython/pull/24498 ___ Python tracker ___

[issue43174] Windows: Use /utf-8 compiler flag

Steve Dower added the comment: The new property should go into PCbuild/pyproject.props, but otherwise seems like an okay change. It *will* cause any string literals (const char *) to be UTF-8, but they ought to all be ASCII anyway. It shouldn't affect resource files, because those have a co

[issue43174] Windows: Use /utf-8 compiler flag

Change by Karthikeyan Singaravelan : -- components: +Windows nosy: +paul.moore, steve.dower, tim.golden, zach.ware ___ Python tracker ___ __

[issue43174] Windows: Use /utf-8 compiler flag

New submission from Inada Naoki : When building Python on Windows Japanese environment, several warnings are shown. ``` C:\Users\songo\source\repos\cpython\Modules\_sha3\kcp\KeccakSponge.h(1,1): warning C4819: ファイルは、現在のコード ページ (932) で表示できない文字を含んでいます。データの損失を防ぐために、ファイルを Unicode 形式で保存してください。 [C: